adds typescript support - #4
Merged
Merged
Conversation
Vincent Biret (baywet)
commented
Dec 29, 2020
Vincent Biret (baywet)
commented
Member
- adds typescript support
- light refactoring of the imports
- light refactoring of parameters classes management
- adds import support for all block types - light refactoring for the import section
Vincent Biret (baywet)
requested a review
from Darrel (darrelmiller)
as a code owner
December 29, 2020 20:22
| var typeName = TranslateType(code.Name, code.Schema); | ||
| if (code.ActionOf) | ||
| { | ||
| var indentFactor = 4; |
There was a problem hiding this comment.
What's the indentfactor for? Why would some blocks have bigger indents than others? I understand that languages may have different indent values, but why allow it to be varied per language element.
Member
Author
There was a problem hiding this comment.
that's for the anonymous type declaration in the methods parameters. We don't absolutely need it, but it looks nicer.
- refactors refiners
Darrel (darrelmiller)
approved these changes
Dec 29, 2020
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.