Repository navigation
Fix panel interaction-state border restoration - #1502
Open
PaperHammer (PaperHammer) wants to merge 1 commit into
Open
PaperHammer (PaperHammer) wants to merge 1 commit into
PaperHammer (PaperHammer) wants to merge 1 commit into
Conversation
PaperHammer (PaperHammer)
requested a review
from Chris Anderson (codemonkeychris)
as a code owner
November 13, 2026 04:43
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1474, which added panel border modifier support and interaction-state border restoration.
This fixes two remaining cases on Grid, StackPanel, and RelativePanel:
Changes
The regression tests verify that updates reuse the same native control, the hover brush is applied, and hover-out restores the expected normal brush. The null-brush case also checks that the temporary local value is released.
Validation
4cd639795f7974af2018c99797d79d6c93edbd56, the regression assertions fail in 9 places across the three panel types.git diff --checkpasses.Tests run against real WinUI controls and use the existing internal hook to drive hover transitions without synthesizing pointer input.
Scope
No public API changes. Updating normal properties during an active hover, interaction-configuration removal cleanup, and animation cleanup are deferred to separate follow-up work.