Skip to content

Build against newer ConPTY's #714

Description

@cpendery

Issue description

Right now, node-pty / conpty flushes osc sequences so they don't appear inline with the terminal text. According to microsoft/terminal#17313, this issue has been addressed and is targeted for Terminal v1.23 in November 2024 according to microsoft/terminal#17643. This would help with Git Bash support in VSCode, and I'd like to leverage it before it gets included in Windows 11 distributions (to avoid the gap between Terminal & Windows conPTY versions).

Is there a way node-pty can be built against a set version of conpty instead of the one bundled with Windows?

Activity

  1. changed the title [-]Build against newer conPTY's[/-] [+]Build against newer ConPTY's[/+] on Sep 13, 2024
  2. cpendery commented on Sep 13, 2024

    @cpendery
    MemberAuthor

    There is a thread from @DHowett here that describes how they are publishing NuGet versions of ConPTY along with its required OpenConsole.exe. Maybe we could leverage this Daniel Imms (@Tyriar)?

  3. lydell commented on Sep 13, 2024

    @lydell
    Contributor

    A bundled conpty was added here: #694

    The maintainers of this repo have worked hard on making that feature stable since: https://github.com/microsoft/node-pty/pulls?q=sort%3Aupdated-desc+is%3Apr+is%3Aclosed

    Beta versions are automatically published when things are merged into main. At the time of this writing, the latest beta version is 1.1.0-beta21.

  4. cpendery commented on Sep 13, 2024

    @cpendery
    MemberAuthor

    Closing and just tracking microsoft/vscode#224488 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions