Repository navigation
Fix EP assignment reporting after NHWC layout transformation - #33184
Merged
mirounga merged 1 commit intoOct 8, 2026
Merged
Conversation
Track provisional assignments from the current NHWC layout pass so singleton capabilities produce assignment records without reporting previously finalized nodes again.
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
Author
|
Edward Chen (@edgchen1) Tianlei Wu (@tianleiwu) — could you review this fix for #32998? It tracks provisional assignments from the current NHWC pass so singleton assignment records are emitted without duplicating records when function inlining reruns partitioning. Regression coverage includes both layouts, both inlining modes, and reconstructed NHWC Conv nodes. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The targeted fix correctly distinguishes current layout-pass assignments and includes coverage for transformed and repeatedly partitioned graphs.
0 open findings
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
mirounga
approved these changes
Oct 8, 2026
This was referenced Oct 9, 2026
This was referenced Oct 14, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NHWC layout transformation provisionally assigns nodes before final capability processing. The singleton admission check rejects these already-tagged nodes, omitting assignment records despite successful execution.
Track provisional assignments from the current layout pass and admit their singleton capabilities. Continue rejecting assignments finalized in earlier rounds to prevent duplicate records after function inlining.
Add regression coverage for unchanged singleton nodes, repeated partitioning in both layouts, and reconstructed NHWC Conv nodes.
Fixes #32998.
Validation