Repository navigation
(WIP) [js/web] WebGL backend refactor - #8576
Closed
Yulong Wang (fs-eire) wants to merge 62 commits into
Closed
Yulong Wang (fs-eire) wants to merge 62 commits into
Yulong Wang (fs-eire) wants to merge 62 commits into
Conversation
…untime into fs-eire/ort-web-refactor
…untime into fs-eire/ort-web-refactor
…untime into fs-eire/ort-web-refactor
Yulong Wang (fs-eire)
requested review from
Du Li (duli2012) and
Sunghoon Choi (hanbitmyths)
August 1, 2021 21:37
Contributor
Author
|
wrong source branch. closed and replaced by #8586 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: This PR contains several changes to the WebGL backend framework code. The major changes are:
ProgramInfoandRunDatafor operator implementations. Previously it's designed based on the assumption that each operator will be implemented by using exactly 1 WebGL shader program, which is proved to be false. The old operator interface is replaced by a function-based one, usingWebGLInferenceHandler.run()to run a program, which can be called multiple times in one operator's implementation.createProgramInfoandcreateRunDataand use one implementation function.ProgramInfoLoaderfor caching reusable program info. (WIP)The behavior should not be changed before vs. after the refactoring.
Benefit of this change: