Followup to #190: harden release job and drop arm64 scaffolding#203
Merged
Conversation
pinodeca
force-pushed
the
followup/package-release-amd64-cleanup
branch
from
7503cf4 to
03e4ed9
Compare
The build/validate matrix and README only target amd64, so the arm64 branches in the packaging scripts were dead code. Remove them so the scripts reject unsupported architectures explicitly.
- Scope contents:write to the release job only; the rest of the workflow runs read-only (least privilege). - Upload the .deb files as release assets directly instead of wrapping them in zips, matching the README's documented asset names. - Publish a SHA256SUMS file so downloaders can verify assets. - Drop the now-unused zip packaging step and build dependency.
pinodeca
force-pushed
the
followup/package-release-amd64-cleanup
branch
from
03e4ed9 to
b65759a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #190 (merged) addressing review feedback and self-review items that were not part of the squashed merge.
Changes
arm64/aarch64branches inscripts/package-deb.shandscripts/validate-deb-package.shwere dead code. They now reject unsupported architectures explicitly. (Addresses the Copilot review comments on Add release package workflow #190 about the arm64 description/implementation mismatch.)contents: writeto thereleasejob only; the rest of the workflow runs withcontents: read..debassets directly — upload the.debfiles as release assets instead of wrapping them in zips, matching the README's documented asset names. Removes the now-unused zip step andzipbuild dependency.SHA256SUMSfile so downloaders can verify release assets; README updated to mention it.Validation
python3 -c "import yaml; yaml.safe_load(...)"on the workflowbash -non both packaging scriptsgit diff --check