Skip to content

fix(cli): parse negative numbers as positional arguments #42324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Lazizbek Ergashev (lazerg) wants to merge 2 commits into from
Closed

fix(cli): parse negative numbers as positional arguments #42324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17b058b
fix(cli): parse negative numbers as positional arguments
lazerg Aug 20, 2026
8f42f73
fix(cli): handle negative numbers without a leading digit
lazerg Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/playwright-core/src/tools/cli-client/minimist.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export function minimist(args: string[], opts?: MinimistOptions): MinimistArgs {
} else {
setArg(key, strings[key] ? '' : true);
}
} else if ((/^-[^-]+/).test(arg)) {
} else if ((/^-[^-]+/).test(arg) && !(/^-\.?\d/).test(arg)) {
const letters = arg.slice(1, -1).split('');

let broken = false;
Expand Down
1 change: 1 addition & 0 deletions packages/playwright-core/src/tools/skills/playwright-cli/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ playwright-cli mousedown right
playwright-cli mouseup
playwright-cli mouseup right
playwright-cli mousewheel 0 100
playwright-cli mousewheel 0 -100
```

### Save as
Expand Down
10 changes: 9 additions & 1 deletion tests/mcp/cli-parsing.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/

import { test, expect } from './cli-fixtures';
import { test, expect, eventsPage } from './cli-fixtures';

test('unknown option', async ({ cli, server }) => {
const { error, exitCode } = await cli('open', '--some-option', 'value', 'about:blank');
Expand Down Expand Up @@ -73,6 +73,14 @@ test('wrong argument type', async ({ cli, server }) => {
expect(press.exitCode).toBe(0);
});

test('negative number argument', { annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/42321' } }, async ({ cli, server }) => {
server.setContent('/', eventsPage, 'text/html');
await cli('open', server.PREFIX);
const { exitCode } = await cli('mousewheel', '0', '-100');
expect(exitCode).toBe(0);
await expect.poll(() => cli('snapshot').then(result => result.inlineSnapshot)).toContain('wheel 0 -100');
});

test('should preserve leading zeros in string arguments', async ({ cli, server }) => {
server.setContent('/', `<input type=text>`, 'text/html');
await cli('open', server.PREFIX);
Expand Down