Skip to content

feat(firefox): roll to r1544 - #42631

Merged
Dmitry Gozman (dgozman) merged 1 commit into
mainfrom
roll-into-pw-firefox/1544
Sep 9, 2026
Merged

Dmitry Gozman (dgozman) merged 1 commit into
mainfrom
roll-into-pw-firefox/1544

Conversation

@microsoft-playwright-automation

@microsoft-playwright-automation microsoft-playwright-automation Bot commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

Browser build: https://github.com/microsoft/playwright-browsers/commit/50445f32fd98c5e19d1fdd3ee37b8e7af336bdda. Build has full platform coverage - check that all tests pass there.

References #42565.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

6 flaky ⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-goto.spec.ts:90 › should work with Cross-Origin-Opener-Policy `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-page] › page/page-leaks.spec.ts:85 › click should not leak `@webkit-ubuntu-22.04-node20`

51411 passed, 1240 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Test results for "MCP"

3 failed
❌ [chrome] › mcp/annotate.spec.ts:269 › should start dashboard and annotate when no dashboard is running @mcp-windows-latest-chrome
❌ [firefox] › mcp/cli-core.spec.ts:77 › click with --modifiers @mcp-windows-latest-firefox
❌ [msedge] › mcp/annotate.spec.ts:417 › should cancel browser_annotate when the MCP client disconnects @mcp-windows-latest-msedge

8345 passed, 1376 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

🟢 No real failures — all three are pre-existing MCP flakes

Hi, I'm the Playwright bot and I took a look at the CI on this Firefox roll (r1544).

The "tests 1" report has 0 failures (6 flaky, all retried green). The only reds are 3 MCP tests, and every one of them fails on SHAs this roll can't be responsible for — two of them aren't even Firefox. The roll changes the Firefox binary only; nothing here points back to it. The PR is clear.

Details

Overall: this Firefox roll only bumps the Firefox browser build. Two of the three failures are on Chrome/Edge — outside anything the roll touches — and the one Firefox failure flakes on unrelated main pushes. No signal that the roll caused any of these.

Pre-existing flake / infra

Triaged by the Playwright bot - agent run

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

3 failed
❌ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:101 › should connectOverCDP and manage downloads in default context @msedge-dev-windows-latest
❌ [chromium-library] › library/chromium/oopif.spec.ts:179 › should take screenshot @chromium-macos-15-xlarge
❌ [android-page] › page/page-click-scroll.spec.ts:160 › should scroll instantly on retry when scroll-behavior is smooth

30 flaky ⚠️ [chromium-library] › library/chromium/css-coverage.spec.ts:112 › should report stylesheets across navigations `@chromium-macos-15-large`
⚠️ [chromium-page] › page/page-add-init-script-callback.spec.ts:50 › should pass arguments to the callback `@chromium-macos-15-large`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:213 › should intercept service worker requests (main and within) `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:630 › should not reuse utility worlds between two clients `@chrome-windows-latest`
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:147 › cli codegen › should ignore programmatic events `@chrome-windows-latest`
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:89 › cli codegen › should not lead to an error if html gets clicked `@chrome-windows-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:373 › should produce network events, routing, and annotations for Service Worker `@chrome-beta-ubuntu-22.04`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:213 › should intercept service worker requests (main and within) `@chrome-macos-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:373 › should produce network events, routing, and annotations for Service Worker `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:315 › selector generator › should chain text after parent `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:412 › selector generator › should not use input[value] `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:556 › selector generator › should generate title selector `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:604 › selector generator › should prefer role other input[type] `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:617 › selector generator › should generate exact title when necessary `@chrome-macos-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@tracing-firefox`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@tracing-firefox`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-csharp.spec.ts:208 › should print context options method override in mstest if options were passed `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-windows-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-windows-latest`
⚠️ [firefox-library] › library/debug-controller.spec.ts:350 › should highlight inside iframe `@firefox-windows-latest`
⚠️ [firefox-library] › library/signals.spec.ts:25 › should close the browser when the node process closes `@firefox-windows-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/defaultbrowsercontext-1.spec.ts:89 › should support viewport option `@firefox-macos-15-xlarge`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1987 › canvas disabled title `@webkit-macos-15-xlarge`
⚠️ [webkit-library] › library/tracing.spec.ts:533 › should produce screencast frames fit `@webkit-macos-15-xlarge`
⚠️ [webkit-page] › page/page-leaks.spec.ts:136 › expect should not leak `@webkit-macos-15-xlarge`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1915 › should not leak recorders `@webkit-macos-15-large`

110762 passed, 4725 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

🟢 No real failures from this roll — three pre-existing Chromium/Android issues

Hi, I'm the Playwright bot and I took a look at the CI on this Firefox roll (r1544).

This PR swaps the Firefox binary only — the diff is entirely browser_patches/firefox/* plus the Firefox revision in browsers.json. The three reds in the latest "tests 2" report are all Chromium/Android tests, and each one already fails on SHAs this roll can't be responsible for. Nothing here traces back to the roll. The PR is clear.

Details

Overall: a Firefox binary bump can't reach a Chromium CDP/OOPIF path or an Android click test. Every failure below is reproduced off this PR — on main push builds or long-running snapshot mismatches — so none of them is new signal from the roll.

Pre-existing flake / infra

  • [chromium-library] › library/chromium/oopif.spec.ts:179 › should take screenshot — pre-existing snapshot mismatch on the macOS xlarge runners. Failed 16 of 1011 runs, every one on chromium-macos-14/15-xlarge, all with the same diff (8207 pixels (ratio 0.04) off screenshot-oopif.png), across unrelated main push builds from Aug 3 through Sep 8. Chromium-only, so a Firefox roll doesn't touch it.

  • [android-page] › page/page-click-scroll.spec.ts:160 › should scroll instantly on retry when scroll-behavior is smooth — broken on main, not by this PR. All 3 of its runs in the DB fail with the same page.click: Timeout ... waiting for locator('button'), and two of them are main push builds — including 4302dbb9, this PR's own base commit. It's failing independently of the roll (Android runs on Chromium anyway): 🟥🟥🟥

  • [chromium-library] › library/chromium/connect-over-cdp.spec.ts:101 › should connectOverCDP and manage downloads in default context — a lone 30s timeout on msedge-dev-windows-latest (1 of 1011 runs). Thin cross-run history, but this is an Edge/CDP download flow with a classic timeout signature — a Firefox binary roll can't affect it. One-off infra hiccup, not the roll.

Triaged by the Playwright bot - agent run

@dgozman
Dmitry Gozman (dgozman) merged commit 5ea7ac2 into main Sep 9, 2026
69 of 75 checks passed
@dgozman
Dmitry Gozman (dgozman) deleted the roll-into-pw-firefox/1544 branch September 9, 2026 13:55
cursor Bot pushed a commit to mxschmitt/try-playwright that referenced this pull request Sep 10, 2026
microsoft/playwright#42631 is on @next, not 1.63.0. Frontend CT stays on 1.62.1 because experimental-ct-react has no matching 1.64 package.

Co-authored-by: Max Schmitt <max@schmitt.mx>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant