Set correct HMR client platform - #628
Merged
Merged
Conversation
| NSString *const path = [bundleURL.path substringFromIndex:1]; // Strip initial slash. | ||
| NSString *const host = bundleURL.host; | ||
| NSNumber *const port = bundleURL.port; | ||
| // TODO(macOS ISS#2323203) - we could perhaps infer the platform from the bundleURL's query parameters, instead of hardcoding |
Member
Author
There was a problem hiding this comment.
The bundleURL has a query parameter like platform=macos. If that parameter is always expected to be available, then we could reduce our forked surface by using that query parameter upstream.
Closed
20 of 25 tasks
Anand Rajeswaran (anandrajeswaran)
approved these changes
Oct 2, 2020
Eloy Durán (alloy)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Re-apply fork change to set the right platform in the HMR setup.
Microsoft Reviewers: Open in CodeFlow