Rebasing android patches over RN63 - #641
Merged
Anandraj (mganandraj) merged 2 commits intoOct 28, 2020
Merged
Conversation
…encies on checked-in version of folly, glog & double-conversion
|
Anandraj (mganandraj)
marked this pull request as ready for review
October 28, 2020 04:40
Anandraj (mganandraj)
requested a review
from Eloy Durán (alloy)
as a code owner
October 28, 2020 04:40
Eloy Durán (alloy)
approved these changes
Oct 28, 2020
Eloy Durán (alloy)
left a comment
Member
There was a problem hiding this comment.
Sweet, thanks! I’ve re-enabled the related CI test and it passes 👍
One question, can we remove the follybuild, glog, and double-conversion directories in the root of the repo too?
Closed
20 of 25 tasks
Member
|
Anandraj (@mganandraj) Perhaps this question slipped by:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased relevant patches over RN63 codebase
Removed the dependencies on checked-in version of folly, glog & double-conversion
Please select one of the following
Summary
Rebased relevant patches over RN63 codebase
Removed the dependencies on checked-in version of folly, glog & double-conversion
Changelog
Rebased relevant patches over RN63 codebase
Removed the dependencies on checked-in version of folly, glog & double-conversion
[CATEGORY] [TYPE] - Message
Test Plan
Office experiences are yet to be tested.
Microsoft Reviewers: Open in CodeFlow