fix(macos): add anchor points for applicationWillFinishLaunching(_:) - #2188
Merged
Tommy Nguyen (tido64) merged 1 commit intoAug 19, 2024
Merged
Conversation
Tommy Nguyen (tido64)
requested review from
Jason Morse (JasonVMo) and
Saad Najmi (Saadnajmi)
as code owners
August 19, 2024 09:58
Jamie Birch (shirakaba)
approved these changes
Aug 19, 2024
Jamie Birch (shirakaba)
left a comment
There was a problem hiding this comment.
Looks like it'd do the trick, thanks!
Saad Najmi (Saadnajmi)
approved these changes
Aug 19, 2024
Tommy Nguyen (tido64)
deleted the
tido/macos/anchors-for-application-will-finish
branch
August 19, 2024 13:44
Collaborator
|
Tommy Nguyen (@tido64) Long term, should the ifdefs be more granular? AKA, ifdefs inside the method and only one method definition? |
Member
Author
For |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add anchor points for
applicationWillFinishLaunching(_:)to make it easier for config plugin authors to target the correct override.Platforms affected
Test plan
n/a