[Fabric] Add react-native initWindows --template cpp-app to CI - #12183
Merged
Conversation
Jon Thysell (jonthysell)
marked this pull request as ready for review
September 26, 2023 21:20
Jon Thysell (jonthysell)
enabled auto-merge (squash)
September 26, 2023 23:45
Tatiana Kapos (TatianaKapos)
approved these changes
Sep 27, 2023
Jon Thysell (jonthysell)
pushed a commit
that referenced
this pull request
Oct 16, 2023
## Description PR #12183 show-horned a new variable and branching path in our existing `cli-init.yml` CI job to support the new `react-native init-windows` command. However, this makes the pipeline hard to parse and maintain. This PR factors out the new new project path into a separate set of jobs, so we can leave the "old" pipeline as-is, run both for now, but have and easier time updating the new one (and eventually just delete the old one when it's no longer necessary). ### Type of Change - New feature (non-breaking change which adds functionality) ### Why To make the new new project CI easier to maintain and drift from the old new project CI. ### What Created a new `cli-init-windows.yml` job, which calls a new "template-focused" `react-native-init-windows.yml` template, and also factored out code common to both it and to `react-native-init.yml` (like starting/stopping verdaccio) into reusable templates. ## Screenshots N/A ## Testing Ran the new pipelines ## Changelog Should this change be included in the release notes: _no_
Jon Thysell (jonthysell)
pushed a commit
that referenced
this pull request
Oct 16, 2023
Backport this into 0.73 to keep the pipelines aligned. PR #12183 show-horned a new variable and branching path in our existing `cli-init.yml` CI job to support the new `react-native init-windows` command. However, this makes the pipeline hard to parse and maintain. This PR factors out the new new project path into a separate set of jobs, so we can leave the "old" pipeline as-is, run both for now, but have and easier time updating the new one (and eventually just delete the old one when it's no longer necessary). - New feature (non-breaking change which adds functionality) To make the new new project CI easier to maintain and drift from the old new project CI. Created a new `cli-init-windows.yml` job, which calls a new "template-focused" `react-native-init-windows.yml` template, and also factored out code common to both it and to `react-native-init.yml` (like starting/stopping verdaccio) into reusable templates. N/A Ran the new pipelines Should this change be included in the release notes: _no_
Yajur Grover (YajurG)
pushed a commit
to YajurG/react-native-windows
that referenced
this pull request
Oct 18, 2023
## Description PR microsoft#12183 show-horned a new variable and branching path in our existing `cli-init.yml` CI job to support the new `react-native init-windows` command. However, this makes the pipeline hard to parse and maintain. This PR factors out the new new project path into a separate set of jobs, so we can leave the "old" pipeline as-is, run both for now, but have and easier time updating the new one (and eventually just delete the old one when it's no longer necessary). ### Type of Change - New feature (non-breaking change which adds functionality) ### Why To make the new new project CI easier to maintain and drift from the old new project CI. ### What Created a new `cli-init-windows.yml` job, which calls a new "template-focused" `react-native-init-windows.yml` template, and also factored out code common to both it and to `react-native-init.yml` (like starting/stopping verdaccio) into reusable templates. ## Screenshots N/A ## Testing Ran the new pipelines ## Changelog Should this change be included in the release notes: _no_
Jon Thysell (jonthysell)
pushed a commit
that referenced
this pull request
Oct 20, 2023
Backport PR #12213 into 0.73 ## Description PR #12183 show-horned a new variable and branching path in our existing `cli-init.yml` CI job to support the new `react-native init-windows` command. However, this makes the pipeline hard to parse and maintain. This PR factors out the new new project path into a separate set of jobs, so we can leave the "old" pipeline as-is, run both for now, but have and easier time updating the new one (and eventually just delete the old one when it's no longer necessary). ### Type of Change - New feature (non-breaking change which adds functionality) ### Why To make the new new project CI easier to maintain and drift from the old new project CI. ### What Created a new `cli-init-windows.yml` job, which calls a new "template-focused" `react-native-init-windows.yml` template, and also factored out code common to both it and to `react-native-init.yml` (like starting/stopping verdaccio) into reusable templates. ## Screenshots N/A ## Testing Ran the new pipelines ## Changelog Should this change be included in the release notes: _no_
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the usage of our new
init-windowscommand, with the new fabric-basedcpp-apptemplate, to our CI, so we don't break it as we make changes.Type of Change
Why
We're still making (breaking) changes to the Composition surface area, so we want to make sure that changes made to the in-repo fabric apps also get reflected in the new app template.
What
Modifies our existing CLI test workflows to optionally use the new command instead. Also makes some changes to how the init code reads files recursively, which wasn't working in CI.
Screenshots
N/A
Testing
Verified the workflows ran.
Changelog
Should this change be included in the release notes: no
Microsoft Reviewers: Open in CodeFlow