[Fabric] Change Switch thumb to use composition animations - #12207
Merged
Tatiana Kapos (TatianaKapos) merged 7 commits intoOct 17, 2023
Merged
[Fabric] Change Switch thumb to use composition animations#12207Tatiana Kapos (TatianaKapos) merged 7 commits into
Tatiana Kapos (TatianaKapos) merged 7 commits into
Conversation
Comment on lines
+113
to
+122
| [webhosthidden] | ||
| [experimental] | ||
| interface ISwitchThumbVisual | ||
| { | ||
| IVisual InnerVisual { get; }; | ||
| void Size(Windows.Foundation.Numerics.Vector2 size); | ||
| void Position(Windows.Foundation.Numerics.Vector2 position); | ||
| Boolean IsVisible { get; set; }; | ||
| void Color(Windows.UI.Color color); | ||
| } |
There was a problem hiding this comment.
Is there a write up anywhere about why/when you need to create these visual wrappers? (as opposed to talking to a generic visual directly) If not, maybe a MD file in the Fabric/Composition directory that describes how to approach this? Is this to enable compositor abstraction (system/lifted/airspace)?
Contributor
Author
There was a problem hiding this comment.
I have a write-up in the internal One-Note, but's it's very minimal. Once it's filled out more, I can add it as a MD file! :)
Jon Thysell (jonthysell)
approved these changes
Oct 6, 2023
pull Bot
pushed a commit
to waqarahmadweb/react-native-windows
that referenced
this pull request
Oct 10, 2023
…#12207) * add skeleton code * adds offset animation * add color and size with pointscalefactor * adds ability to switch composition * remove old code * Change files * fix build
Yajur Grover (YajurG)
pushed a commit
to YajurG/react-native-windows
that referenced
this pull request
Oct 18, 2023
…#12207) * add skeleton code * adds offset animation * add color and size with pointscalefactor * adds ability to switch composition * remove old code * Change files * fix build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes Switch's thumb to use composition animations and adds animation for path
Type of Change
Why
First part of #12188, still need to animate thumb increasing in size on hover
What
Add thumb visual to CompositionContextHelper
Screenshots
Before (switch's are styled differently so color is different!)
Playground-composition_O4pUFtItIz.mp4
After
Playground-composition_pzQppcD0qu.mp4
Testing
tested locally on both devbox and laptop to check sizing!
Changelog
no
Microsoft Reviewers: Open in CodeFlow