Skip to content

Implement WebSocketTurboModuleProxy - #12214

Merged
Julio César Rocha (JunielKatarn) merged 10 commits into
microsoft:mainfrom
jurocha-ms:ws-turboproxy
Oct 12, 2023
Merged

Implement WebSocketTurboModuleProxy#12214
Julio César Rocha (JunielKatarn) merged 10 commits into
microsoft:mainfrom
jurocha-ms:ws-turboproxy

Conversation

@JunielKatarn

@JunielKatarn Julio César Rocha (JunielKatarn) commented Oct 7, 2023

Copy link
Copy Markdown
Contributor

Description

Implement WebSocket proxy for TurboModule variants.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Why

WebSocket TurboModule variant does not communicate with its Blob counterpart when it requires to send binary data through this protocol.

What

Define WebSocketTurboModuleProxy and expose it to the Blob resource via shared property bag (i.e. ReactContext::Properties()).

Microsoft Reviewers: Open in CodeFlow

Comment thread vnext/Shared/Modules/WebSocketModule.cpp Outdated
Comment thread vnext/Shared/Modules/WebSocketModule.cpp

@aeulitz Andreas Eulitz (aeulitz) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JunielKatarn
Julio César Rocha (JunielKatarn) merged commit f4fba46 into microsoft:main Oct 12, 2023
Julio César Rocha (JunielKatarn) added a commit to jurocha-ms/react-native-windows that referenced this pull request Oct 12, 2023
* Implement WebSocketTurboModuleProxy

* Change files

* Define common constant for proxy ID name

* Define common constant for shared state ID name

* Define common constant for content handler ID name

* clang format
Julio César Rocha (JunielKatarn) added a commit to jurocha-ms/react-native-windows that referenced this pull request Oct 12, 2023
* Implement WebSocketTurboModuleProxy

* Change files

* Define common constant for proxy ID name

* Define common constant for shared state ID name

* Define common constant for content handler ID name

* clang format
Andrew Coates (acoates-ms) pushed a commit that referenced this pull request Oct 12, 2023
* Implement WebSocketTurboModuleProxy (#12214)

* Implement WebSocketTurboModuleProxy

* Change files

* Define common constant for proxy ID name

* Define common constant for shared state ID name

* Define common constant for content handler ID name

* clang format

* Remove change file

* Change files
Andrew Coates (acoates-ms) pushed a commit that referenced this pull request Oct 12, 2023
* Implement WebSocketTurboModuleProxy (#12214)

* Implement WebSocketTurboModuleProxy

* Change files

* Define common constant for proxy ID name

* Define common constant for shared state ID name

* Define common constant for content handler ID name

* clang format

* Remove change file

* Change files
Yajur Grover (YajurG) pushed a commit to YajurG/react-native-windows that referenced this pull request Oct 18, 2023
* Implement WebSocketTurboModuleProxy

* Change files

* Define common constant for proxy ID name

* Define common constant for shared state ID name

* Define common constant for content handler ID name

* clang format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants