Conditionally register WebSocket Cxx module - #12218
Merged
Julio César Rocha (JunielKatarn) merged 2 commits intoOct 10, 2023
Merged
Conversation
Julio César Rocha (JunielKatarn)
requested a review
from a team
as a code owner
October 10, 2023 01:50
Julio César Rocha (JunielKatarn)
requested review from
a team and
Andrew Coates (acoates-ms)
October 10, 2023 01:51
Vladimir Morozov (vmoroz)
approved these changes
Oct 10, 2023
Andrew Coates (acoates-ms)
approved these changes
Oct 10, 2023
Julio César Rocha (JunielKatarn)
added a commit
that referenced
this pull request
Oct 11, 2023
* Conditionally register WebSocket Cxx module * Change files
Julio César Rocha (JunielKatarn)
added a commit
that referenced
this pull request
Oct 11, 2023
* Conditionally register WebSocket Cxx module * Change files
Andrew Coates (acoates-ms)
added a commit
that referenced
this pull request
Oct 11, 2023
* Conditionally register WebSocket Cxx module (#12218) * Conditionally register WebSocket Cxx module * Change files * Remove change files * Change files --------- Co-authored-by: Andrew Coates <30809111+acoates-ms@users.noreply.github.com>
Yajur Grover (YajurG)
pushed a commit
to YajurG/react-native-windows
that referenced
this pull request
Oct 18, 2023
* Conditionally register WebSocket Cxx module * Change files
Andrew Coates (acoates-ms)
added a commit
that referenced
this pull request
Oct 18, 2023
* Conditionally register WebSocket Cxx module (#12218) * Conditionally register WebSocket Cxx module * Change files * Remove change files * Change files --------- Co-authored-by: Andrew Coates <30809111+acoates-ms@users.noreply.github.com> Co-authored-by: Jon Thysell <jthysell@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow using the Cxx WebSocket module instead of its TurboModule variant.
Type of Change
Why
Using the WebSocket TurboModule could lead to a memory leak on application shutdown.
This issue is currently under investigation.
What
facebook::react::DevSettings::useWebSocketTurboModule.UseWebSocketTurboModuleproperty.Microsoft Reviewers: Open in CodeFlow