Integrate RN Nightly 10/02 - #12243
Merged
Yajur Grover (YajurG) merged 5 commits intoOct 16, 2023
Merged
Conversation
Yajur Grover (YajurG)
changed the title
Yajur Grover (YajurG)
marked this pull request as ready for review
October 16, 2023 18:12
|
|
||
| // Polyfill of C++ 23 to_underlying() | ||
| // https://en.cppreference.com/w/cpp/utility/to_underlying | ||
| template <typename T> |
Contributor
Author
There was a problem hiding this comment.
This method was implemented with auto e as the parameter upstream, as per the link in the comments, but that was causing an error "a parameter cannot have a type that contains 'auto'" - want to confirm if current change is an appropriate fix. From what I found, it looked like the error was related to the current version of C++ we are using.
Contributor
There was a problem hiding this comment.
I think this looks okay.
Jon Thysell (jonthysell)
approved these changes
Oct 16, 2023
|
|
||
| // Polyfill of C++ 23 to_underlying() | ||
| // https://en.cppreference.com/w/cpp/utility/to_underlying | ||
| template <typename T> |
Contributor
There was a problem hiding this comment.
I think this looks okay.
Yajur Grover (YajurG)
added a commit
to YajurG/react-native-windows
that referenced
this pull request
Oct 18, 2023
* Integrate 10/02 * Integrate 10/02 * Change files * fixed ReactCommon errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Integration
What
react/react-native@2de964c...0371014
Relevant PRs:
Microsoft Reviewers: Open in CodeFlow
Microsoft Reviewers: Open in CodeFlow