Implemented Uwp ScriptStore and PreparedScriptStore to allow caching scripts as bytecdoes - #2653
Merged
14 commits merged intoJun 21, 2019
Merged
Conversation
…pers from bytecode manager
ghost
added
the
|
|
Stephen Crain (stecrain)
requested review from
Andrew Coates (acoates-ms),
Andy Himberger (ahimberg),
Adam Krantz (akrantz) and
kmelmon
June 20, 2019 18:29
Contributor
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
I like this PR but I also worked with Joseph on it. So another set of eyes would be great |
… source url in naming of bytecode file
Contributor
Author
|
/azp run |
Contributor
|
Commenter does not have sufficient privileges for PR 2653 in repo microsoft/react-native-windows |
Contributor
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 1 pipeline(s). |
Stephen Crain (stecrain)
approved these changes
Jun 20, 2019
Contributor
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 1 pipeline(s). |
Stephen Crain (stecrain)
added
the
AutoMerge
|
Hello Stephen Crain (@stecrain)! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set settings.EnableByteCodeCacheing to true in the ReactInit.cpp file to enable this feature. Default will be false.
Helps with reducing boot up time.
Microsoft Reviewers: Open in CodeFlow