Implement accessibilityState (#4617) - #4624
Merged
5 commits merged intoApr 17, 2020
Merged
Conversation
* Implement AccessibilityState * formatting * Change files * bring back accessibilityStates to port back to 0.61 * formatting * handle mixed state * update test * prettier fixes
kmelmon
marked this pull request as ready for review
April 16, 2020 19:15
Nick Gerleman (NickGerleman)
approved these changes
Apr 16, 2020
Nick Gerleman (NickGerleman)
left a comment
Nick Gerleman (NickGerleman)
left a comment
Contributor
There was a problem hiding this comment.
kmelmon would you mind also replacing "prerelease" with "patch" in your changefile? Due to a Beachball bug we will otherwise no-op instead of showing an error, since we disallow pre-release bumps for stable branches.
Ken Chau (@kenotron) Andrew Coates (@acoates-ms) we should really try to fix this bug.
Contributor
Author
|
done. the commit message says it all... In reply to: 395017337 [](ancestors = 395017337) |
kmelmon
added
the
AutoMerge
|
Hello kmelmon! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick of 9718f84 into 0.61-stable