Repository navigation
fix(metro-config): fix assets outside of project root not rendering - #3910
Merged
Merged
Conversation
Tommy Nguyen (tido64)
requested review from
Jason Morse (JasonVMo),
Saad Najmi (Saadnajmi) and
acoates-ms
as code owners
January 5, 2026 15:54
3 of 5 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Jason Morse (JasonVMo)
approved these changes
Jan 5, 2026
Tommy Nguyen (tido64)
enabled auto-merge (squash)
January 6, 2026 11:53
Tommy Nguyen (tido64)
force-pushed
the
tido/metro-config/rewrite-assets
branch
from
January 7, 2026 11:23
b4f8384 to
8192942
Compare
Tommy Nguyen (tido64)
force-pushed
the
tido/metro-config/rewrite-assets
branch
2 times, most recently
from
January 8, 2026 15:49
5e12d55 to
0bdebdf
Compare
Tommy Nguyen (tido64)
force-pushed
the
tido/metro-config/rewrite-assets
branch
from
January 8, 2026 15:51
0bdebdf to
df9c55f
Compare
Jason Morse (JasonVMo)
approved these changes
Jan 8, 2026
Jason Morse (JasonVMo)
left a comment
Jason Morse (JasonVMo)
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. The ../ escaping is hardcoded to posix style paths, will these still be in this style on Windows?
Member
Author
This should be fine because they're urls (which is also the cause of all the issues). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed assets outside of project root not rendering.
Resolves #3909.
Test plan
The close button should be rendered.