Disable rtti / exceptions on the non-Windows builds. - #15
Merged
Conversation
RTTI makes the binaries bigger, exceptions make life harder for optimisers. Neither are actually used. This doesn't preclude anything #including snmalloc.h with RTTI enabled, it just disables it in the shim libraries and tests. The FreeBSD libc builds were already doing this with no ill effect.
David Chisnall (davidchisnall)
requested a review
from Matthew Parkinson (mjp41)
February 6, 2019 17:39
Matthew Parkinson (mjp41)
approved these changes
Feb 6, 2019
Matthew Parkinson (mjp41)
pushed a commit
to mjp41/snmalloc
that referenced
this pull request
Jan 27, 2026
…ules/snmalloc-sys/snmalloc-ef77bcc Bump snmalloc-sys/snmalloc from `3775a62` to `ef77bcc`
Draft
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RTTI makes the binaries bigger, exceptions make life harder for
optimisers. Neither are actually used.
This doesn't preclude anything #including snmalloc.h with RTTI enabled,
it just disables it in the shim libraries and tests.
The FreeBSD libc builds were already doing this with no ill effect.