Re-enable LocalizationTests and LocalizationFailingTests

[Evangelink]

Fixes #9295.

The TerminalResources.*.xlf translations for French and Spanish have now flowed for every string asserted by LocalizationTests and LocalizationFailingTests, so the temporary [Ignore] attributes (and their explanatory comments) added in #9295 are removed.

Notes

• The only string still marked state="new" in the fr/es xlf files is ErroredAssembliesHeader ("Errored assemblies:"), which none of these tests assert on, so it does not block re-enabling. It may still be worth tracking separately for the downstream loc pipeline (icxLocBug).

Validation

• .\build.cmd -pack
• dotnet test on Microsoft.Testing.Platform.Acceptance.IntegrationTests filtered to ~Localization: 12/12 passed.

[Copilot]

Pull request overview

This PR re-enables the LocalizationTests and LocalizationFailingTests acceptance test classes by removing the temporary class-level [Ignore] attributes (and their explanatory comments) that were added in #9295. Those ignores were a stop-gap while OneLocBuild repeatedly reverted the newly-added TerminalResources.*.xlf targets back to English, which made the tests fail on every localization check-in. Now that proper French and Spanish translations have flowed for all strings these tests assert, the tests can run again, restoring coverage of MTP's terminal-summary localization and UI-language precedence behavior.

Changes:

• Remove the [Ignore] attribute + comment from LocalizationTests.
• Remove the [Ignore] attribute + comment from LocalizationFailingTests.

Show a summary per file

File	Description
test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/LocalizationTests.cs	Removes the temporary [Ignore] and comment so the French/Spanish summary and UI-language precedence tests run again.
test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/LocalizationFailingTests.cs	Removes the temporary [Ignore] and comment so the French failure-summary test runs again.

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 0
• Review effort level: Medium

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

✅ 22/22 dimensions clean — no findings.

Summary: Straightforward re-enablement of LocalizationTests and LocalizationFailingTests by removing the class-level [Ignore] attributes and their explanatory comments, now that OneLocBuild has shipped proper TerminalResources.*.xlf translations (resolving #9295). The existing test assertions (Unicode normalization, NBSP handling, locale precedence) are well-crafted for this domain. No flakiness, isolation, or correctness concerns.

Dimension breakdown (all N/A or clean)

#	Dimension	Verdict
1	Algorithmic Correctness	N/A — no logic changes
2	Threading & Concurrency	N/A — no shared state changes
3	Security & IPC Contract Safety	N/A — no security-surface changes
4	Public API & Binary Compatibility	N/A — test-only change
5	Performance & Allocations	N/A — no hot-path changes
6	Cross-TFM Compatibility	N/A — no TFM-specific code touched
7	Resource & IDisposable Management	N/A — no resource changes
8	Defensive Coding at Boundaries	N/A — no boundary changes
9	Localization & Resources	✅ Clean — removes stale workaround, no .xlf edits
10	Test Isolation	✅ Clean — tests use per-execution assets and env vars
11	Assertion Quality	✅ Clean — appropriate normalization helpers for locale output
12	Flakiness Patterns	✅ Clean — no timing, hardcoded ports, or order-dependent assertions
13	Test Completeness & Coverage	N/A — re-enabling existing tests, no new code
14	Data-Driven Test Coverage	N/A — no new data rows
15	Code Structure & Simplification	✅ Clean — pure removal
16	Naming & Conventions	N/A — no new identifiers
17	Documentation Accuracy	✅ Clean — removes now-outdated comment
18	Analyzer & Code Fix Quality	N/A — no analyzer changes
19	IPC Wire Compatibility	N/A — no serialization changes
20	Build Infrastructure & Dependencies	N/A — no build changes
21	Scope & PR Discipline	✅ Clean — single concern, references #9295, notes remaining string for separate tracking
22	PowerShell Scripting Hygiene	N/A — no .ps1 changes

[github-actions]

🧪 Test quality grade — PR #9643

All 4 tests re-enabled by removing the class-level [Ignore] attribute.

Grade	Test	Notes
A (90–100)	mod LocalizationFailingTests. Execution_ WithFailingTest_ OutputContainsTranslatedFailureSummary	Solid AAA with exit-code + French failure summary + count assertions; consider adding "English not present" negative checks for parity with sibling tests.
A (90–100)	mod LocalizationTests. Execution_ WithFrenchLocale_ OutputContainsTranslatedSummary	No issues found. Comprehensive: exit-code, normalized French summary, all four count labels, plus two negative assertions confirming English strings are absent.
A (90–100)	mod LocalizationTests. Execution_ WithSpanishLocale_ OutputContainsTranslatedSummary	No issues found. Mirrors the French test structure; correctly skips Unicode normalization for Spanish (no NBSP/NFD issues).
A (90–100)	mod LocalizationTests. Execution_ WithTestingPlatformUILanguage_ TakesPrecedenceOverDotnetCLI	No issues found. Precisely tests the env-var precedence contract with both a positive (French present) and negative (Spanish absent) assertion.

_{This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.}

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Grade Tests on PR (on open / sync) workflow. · 60.3 AIC · ⌖ 7.14 AIC · ⊞ 9.5K · [◷]( · ◷)