Skip to content

Fix workspace dependency vulnerabilities - #11926

Merged
Timothee Guerin (timotheeguerin) merged 2 commits into
microsoft:mainfrom
timotheeguerin:fix/workspace-security-dependencies
Sep 11, 2026
Merged

Fix workspace dependency vulnerabilities#11926
Timothee Guerin (timotheeguerin) merged 2 commits into
microsoft:mainfrom
timotheeguerin:fix/workspace-security-dependencies

Conversation

@timotheeguerin

Copy link
Copy Markdown
Member

The root pnpm workspace has 11 open Dependabot alerts, including Astro image-processing RCE and denial-of-service vulnerabilities in request parsing.

Resolve those alerts with patched versions:

Package Updated version
Astro 7.2.8
Sharp 0.35.4
Morgan 1.12.0
Multer 2.3.0
js-yaml 3.15.2 and 4.3.2
qs 6.16.0

Refresh all affected transitive copies and the generated HTTP server dependency version. The excluded C#/Java/Python emitter lockfiles remain unchanged.

Azure feed follow-up: all seven security target tarballs and uncached macOS ARM64 Sharp downloads are available. Windows and other optional Sharp platform artifacts still return HTTP 401. A full Azure-registry install also encounters a 401 during pnpm's supply-chain check for the existing @astrojs/compiler-binding-linux-arm64-gnu package. Those feed artifacts still need to be made available.

@pkg-pr-new

pkg-pr-new Bot commented Sep 10, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@typespec/http-server-js@11926

commit: 30ce47b

@github-actions

Copy link
Copy Markdown
Contributor

All changed packages have been documented.

  • @typespec/http-server-js
Show changes

@typespec/http-server-js - dependencies ✏️

Update the generated server's morgan dependency to 1.12.0 to address log-forging vulnerabilities.

@typespec/spector - dependencies ✏️

Update morgan to 1.12.0, multer to 2.3.0, and transitive qs to 6.16.0 to address log-forging, upload limit bypass, and denial-of-service vulnerabilities.

@azure-sdk-automation

azure-sdk-automation Bot commented Sep 10, 2026

Copy link
Copy Markdown

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are limited to dependency/catalog bumps plus corresponding lockfile and changelog updates, with no code-path logic changes introduced.

Pull request overview

This PR updates the root pnpm workspace dependency catalog and lockfile to pull in patched versions that address multiple Dependabot security alerts, and refreshes the HTTP server JS scaffold’s generated dependency version mapping to stay in sync.

Changes:

  • Bump workspace catalog versions for Astro, Sharp, Morgan, and Multer to patched releases.
  • Refresh the root pnpm-lock.yaml so transitive vulnerable versions (e.g., qs, js-yaml) resolve to patched versions.
  • Update @typespec/http-server-js generated dependency definitions and add Chronus entries for the affected packages.
File summaries
File Description
pnpm-workspace.yaml Updates the workspace catalog to the patched versions for key vulnerable dependencies.
pnpm-lock.yaml Refreshes the lockfile to ensure the workspace resolves patched direct/transitive dependency versions.
packages/http-server-js/generated-defs/package.json.ts Updates the generated dependency-version map used by the JS HTTP server scaffold (e.g., morgan 1.12.0).
.chronus/changes/workspace-security-spector-2026-09-10.md Adds a dependencies changelog entry for @typespec/spector security-related dependency bumps.
.chronus/changes/workspace-security-http-server-js-2026-09-10.md Adds a dependencies changelog entry for @typespec/http-server-js scaffold dependency bump.
Review details

Files not reviewed (1)

  • pnpm-lock.yaml: Generated file
  • Files reviewed: 4/5 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI review requested due to automatic review settings September 11, 2026 12:40
@timotheeguerin
Timothee Guerin (timotheeguerin) merged commit b6eec8e into microsoft:main Sep 11, 2026
12 checks passed
@timotheeguerin
Timothee Guerin (timotheeguerin) deleted the fix/workspace-security-dependencies branch September 11, 2026 12:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Sharp platform artifacts remain unavailable from the Azure feed, blocking reliable Windows and other platform installs.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Files not reviewed (1)

  • pnpm-lock.yaml: Generated file
  • Files reviewed: 4/5 changed files
  • Comments generated: 1
  • Review effort level: Lite

Comment thread pnpm-workspace.yaml
rollup-plugin-visualizer: 7.1.1
semver: ^7.8.5
sharp: ^0.35.3
sharp: ^0.35.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants