[opencv4] feat: pass CUDA_ARCHITECTURES#51659
Open
air-hand wants to merge 4 commits into
Open
Conversation
Author
|
@microsoft-github-policy-service agree |
vicroms
reviewed
May 12, 2026
| FILENAME "opencv-cache/nvidia_optical_flow/a73cd48b18dcc0cc8933b30796074191-edb50da3cf849840d680249aa6dbef248ebce2ca.zip" | ||
| SHA512 12d655ac9fcfc6df0186daa62f7185dadd489f0eeea25567d78c2b47a9840dcce2bd03a3e9b3b42f125dbaf3150f52590ea7597dc1dc8acee852dc0aed56651e | ||
| ) | ||
| if(DEFINED CUDA_ARCHITECTURES) |
Member
There was a problem hiding this comment.
This variable lacks documentation, is this supposed to be a well-known environment variable? Otherwise, we may want to add a comment for users of the port to know this is a triplet variable.
Author
There was a problem hiding this comment.
Thanks for your review.
Updated in 3e7fa12
I used CUDA_ARCHITECTURES here to match the existing darknet port pattern.
The name also lines up with CMake's CUDA_ARCHITECTURES target property.
vicroms
requested changes
May 12, 2026
Author
|
Sorry, I missed updating the version database. I've added it now 19d779c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass
CUDA_ARCHITECTURESthrough asCMAKE_CUDA_ARCHITECTURESwhen buildingopencv4with thecudafeature.This lets users configure CUDA architectures from their triplet instead of falling back to OpenCV's default CUDA architecture selection, which can trigger unnecessary CUDA compilation.
./vcpkg x-add-version --alland committing the result.