Skip to content

Add JoinableTaskInternals.IsMainThreadBlockedByAnyJoinableTask method - #1067

Merged
Andrew Arnott (AArnott) merged 2 commits into
microsoft:mainfrom
jialongcheng:dev/jialongcheng/MainThreadBlockedByJoinableTask
Jul 20, 2022
Merged

Andrew Arnott (AArnott) merged 2 commits into
microsoft:mainfrom
jialongcheng:dev/jialongcheng/MainThreadBlockedByJoinableTask

Conversation

@jialongcheng

Copy link
Copy Markdown
Contributor

We still need a way to check whether the main thread is blocked by any joinableTask inside WaitSynchronouslyCore. This reintroduces previous commit 553c404

The change also creates a VS helper class and declare the new API as internal use only.

@AArnott
Andrew Arnott (AArnott) force-pushed the dev/jialongcheng/MainThreadBlockedByJoinableTask branch 2 times, most recently from f5b8f42 to bf93947 Compare July 20, 2022 00:28
@AArnott
Andrew Arnott (AArnott) changed the base branch from main to v17.3 July 20, 2022 00:28
@AArnott Andrew Arnott (AArnott) added this to the v17.3 milestone Jul 20, 2022
@AArnott Andrew Arnott (AArnott) changed the title Dev/jialongcheng/main thread blocked by joinable task Add JoinableTaskInternals.IsMainThreadBlockedByAnyJoinableTask method Jul 20, 2022
@AArnott
Andrew Arnott (AArnott) changed the base branch from v17.3 to main July 20, 2022 00:29
@AArnott Andrew Arnott (AArnott) modified the milestones: v17.3, v17.4 Jul 20, 2022
This re-expose a property on whether JoinableTaskContext has any JoinableTask blocking calls on the main thread

This is based on a revert of commit b0cf150, reversing
changes made to 0847b84.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants