Repository navigation
GraphQL is still used on GH Enterprise #907
Description
Issue Type: Bug
We try to verify if a github repository supports GraphQL by checking
supportsGraphQl(): boolean {
return !!(this.hub && this.hub.graphql);
}
however we always create an AplloClient in hub
return {
octokit,
graphql: new ApolloClient({
link: link(baseUrl, creds.token || ''),
cache: new InMemoryCache,
defaultOptions: {
query: {
fetchPolicy: 'no-cache'
}
}
})
};
Extension version: 1.31.0
VS Code version: Code - Insiders 1.31.0-insider (8f56013e8f66650c1b0b65cc5c502691e307db21, 2019-02-01T18:28:27.157Z)
OS version: Darwin x64 18.2.0
System Info
| Item | Value |
|---|---|
| CPUs | Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200) |
| GPU Status | 2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled rasterization: enabled surface_synchronization: enabled_on video_decode: enabled webgl: enabled webgl2: enabled |
| Load (avg) | 2, 2, 3 |
| Memory (System) | 16.00GB (0.43GB free) |
| Process Argv | -psn_0_3179272 |
| Screen Reader | no |
| VM | 0% |
Activity
rebornix commentedon Feb 1, 2019
Ashi Krishnan (@queerviolet) do you know the proper way to test whether an endpoint support GraphQL or not?
queerviolet commentedon Feb 1, 2019
Probably the most straightforward way is just to try making a query.
[-]GraphQL is still used in GH Enterprise[/-][+]GraphQL is still used on GH Enterprise[/+]