Review comments are missing in description view on GH Enterprise #908

Activity

1. Peng Lyu (rebornix)

   assigned

   Rachel Macfarlane (RMacfarlane)

   ,

   Ashi Krishnan (queerviolet)

   and

   Peng Lyu (rebornix)

   and unassigned

   Ashi Krishnan (queerviolet)

   on Feb 1, 2019
2. Peng Lyu (rebornix)

   added

   bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bug

   importantIssue identified as high-priorityIssue identified as high-priority

   GitHubEnterprise

   on Feb 1, 2019
3. Peng Lyu (rebornix)

   added a commit that references this issue on Feb 1, 2019

   Fix #908.

   This issue will close once commit fb4cba7 is merged into the 'main' branch.

   fb4cba7
4. RMacfarlane commented on Feb 6, 2019

   

   Rachel Macfarlane (RMacfarlane)

   on Feb 6, 2019

   Contributor

   More actions

   fixed by #910
5. Rachel Macfarlane (RMacfarlane)

   closed this as completedon Feb 6, 2019
6. yulrizka commented on Oct 13, 2019

   

   Ahmy Yulrizka (yulrizka)

   on Oct 13, 2019

   Contributor

   More actions

   Rachel Macfarlane (@RMacfarlane), Is adding comments in a pending review for Github Enterprise not supported?

   I tried to play around to make it work, I managed to create pending 'Review' by using octokit.
   but got error while trying to add comment.

   user_id can only have one pending review per pull request
   

   or it should use a different API?
7. RMacfarlane commented on Oct 14, 2019

   

   Rachel Macfarlane (RMacfarlane)

   on Oct 14, 2019

   Contributor

   More actions

   Ahmy Yulrizka (@yulrizka) It should be, though it's possible it's not in older versions.

   There are several different versions of GitHub's API - the REST one that octokit uses (v3), and a new graphql one(v4). The v3 version doesn't support adding comments to pending reviews, you have to create the review all at once. So we're using the v4 version for adding pending comments instead:

   vscode-pull-request-github/src/github/pullRequestManager.ts

   Line 1038 in aae86fd

   async createComment(pullRequest: PullRequestModel, body: string, commentPath: string, position: number): Promise<IComment | undefined> {

   When the extension first starts, it tries to detect if the current repository supports the v4 API or not. Some things have been added to the v4 API over time, so what I'm not sure about is if there's a GitHub Enterprise version that has graphql support, but not that feature