Skip to content

Extension can't be install from market on ./scripts/code-server.sh with nodejs 21 #200934

Closed

Description

@kkocdko
  • VS Code Version: current main branch
  • OS Version: fedora linux 39, kernel 6.6.4-200.fc39.x86_64

Steps to Reproduce:

  1. Enable extension market support for debug, both ./product.json and ./src/vs/platform/product/common/product.ts.
  2. Run ./scripts/code-server.sh to compile, then exit.
  3. Use current nodejs 21 to replace .build/node/v18.17.1/linux-x64/node.
  4. Run ./scripts/code-server.sh, open extension panel, search some name. You can see:

image

This happen only on nodejs 21, not on nodejs 18.

* About running on nodejs 21

The dependencies node-pty and node-spdlog use NAN binding, so them needs recompile, or you can just ignore them.

Or you can use my NAPI port of node-pty. And a faked pure-js spdlog here.

* About this variant of VSCode

The ./scripts/code-server.sh variant runs UI in browser and extension host in nodejs. This variant is used as GitHub Codespace and can be download from https://update.code.visualstudio.com/latest/server-linux-x64-web/insider (or server-win32-x64-web/stable if you want).

* About extension market

VSCode OSS don't have extension market enrtypoint by default, add these content temporarily enabling the market for debugging:

"extensionsGallery": { "serviceUrl": "https://marketplace.visualstudio.com/_apis/public/gallery", "cacheUrl": "https://vscode.blob.core.windows.net/gallery/index", "itemUrl": "https://marketplace.visualstudio.com/items", "controlUrl": "", "recommendationsUrl": "" }

Activity

  1. added this to the milestone on Dec 16, 2023
  2. added
    insiders-releasedPatch has been released in VS Code Insiders
    and removed
    unreleasedPatch has not yet been released in VS Code Insiders
    on Dec 18, 2023
  3. locked and limited conversation to collaborators on Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

insiders-releasedPatch has been released in VS Code Insiders

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions