Skip to content

align acceptance keybindings - #195414

Merged
Megan Rogge (meganrogge) merged 2 commits into
mainfrom
merogge/align-bindings
Oct 11, 2023
Merged

align acceptance keybindings#195414
Megan Rogge (meganrogge) merged 2 commits into
mainfrom
merogge/align-bindings

Conversation

@meganrogge

@meganrogge Megan Rogge (meganrogge) commented Oct 11, 2023

Copy link
Copy Markdown
Collaborator

fix #195280

@meganrogge Megan Rogge (meganrogge) added this to the October 2023 milestone Oct 11, 2023
roblourens
roblourens reviewed Oct 11, 2023
View reviewed changes

@roblourens roblourens left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Run in terminal" uses this one. I didn't think we need a keybinding for this because it's not very useful and we've assumed most people will want copy/paste. It might become more useful with Ulugbek's work though.

@meganrogge

Megan Rogge (meganrogge) commented Oct 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Run in terminal seems much lower of a priority - in particular, for screen reader users.

Copy/paste aren't screen reader friendly.

Hb we go with this for screen reader users and reassign the terminal one to ctrl+/?

Pushed that suggestion.

@roblourens

roblourens commented Oct 11, 2023

Copy link
Copy Markdown
Member

This seems hard to use with a screenreader when you have to remember where you left the cursor so you don't really know where the code is going to go. The two-step copy/paste flow seems easier to me for the same reason it's easier for sighted users. But I'm fine with either set of keybindings.

@meganrogge
Megan Rogge (meganrogge) deleted the merogge/align-bindings branch October 11, 2023 23:13
Alex0007 pushed a commit to Alex0007/vscode that referenced this pull request Oct 26, 2023
@meganrogge @Alex0007
Merge pull request microsoft#195414 from microsoft/merogge/align-bind…
a118d5c 
…ings

align acceptance keybindings
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@roblourens roblourens roblourens approved these changes

Assignees

@meganrogge Megan Rogge (meganrogge)

Labels

None yet

Projects

None yet

Milestone

October 2023

Development

Successfully merging this pull request may close these issues.

align accept keybindings

2 participants

@meganrogge @roblourens