Skip to content

Fix StableEditorBottomScrollState - #212970

Merged
Alexandru Dima (alexdima) merged 1 commit into
mainfrom
alexd/rapid-muskox
May 23, 2024
Merged

Fix StableEditorBottomScrollState#212970
Alexandru Dima (alexdima) merged 1 commit into
mainfrom
alexd/rapid-muskox

Conversation

@alexdima

@alexdima Alexandru Dima (alexdima) commented May 17, 2024

Copy link
Copy Markdown
Member

I think this fixes StableEditorBottomScrollState

But the problem is not completely solved because:

  • there is a call to revealRangeNearTopIfOutsideViewport somewhere in the view zone show code.
  • (when doing "explain this") - when markdown streams in, the view zone grows but nobody calls StableEditorBottomScrollState
  • (when doing "document this") - when edits stream in, I think the view zone grows and also there is a call to revealRangeInCenterIfOutsideViewport

I would continue by figuring out where the view zone changes its height and using StableEditorBottomScrollState there.

@alexdima
Alexandru Dima (alexdima) marked this pull request as ready for review May 17, 2024 14:24
@vscodenpa VS Code Bot (vscodenpa) added this to the May 2024 milestone May 17, 2024
@alexdima
Alexandru Dima (alexdima) enabled auto-merge (squash) May 22, 2024 17:10
@alexdima
Alexandru Dima (alexdima) deleted the alexd/rapid-muskox branch May 23, 2024 06:50
André Silva (andremmsilva) pushed a commit to PIC1G55/vscodeG55 that referenced this pull request May 26, 2024
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants