Fix an issue where defaultLinesDiffComputer does not pass in the timeout variable - #213035
Merged
Henning Dieterichs (hediet) merged 1 commit intoMay 27, 2024
Merged
Henning Dieterichs (hediet) merged 1 commit into
Henning Dieterichs (hediet) merged 1 commit into
Conversation
Author
|
cc Henning Dieterichs (@hediet) the last editor of the line. |
Michael Lively (Yoyokrazy)
assigned
Henning Dieterichs (hediet) and unassigned
Michael Lively (Yoyokrazy)
Henning Dieterichs (hediet)
enabled auto-merge (squash)
May 27, 2024 16:37
Sandeep Somavarapu (sandy081)
approved these changes
May 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #213034
This caller is missing to pass in the timeout variable.
Otherwise it won't respect the
maxComputationTimeMsoption that was passed in incomputeDiffThe definition of the
myersDiffingAlgorithm.computelooks like this