Save on EH diagnostics - #213171
Merged
Merged
Save on EH diagnostics#213171
Conversation
Logan Ramos (lramos15)
previously approved these changes
May 21, 2024
Aaron Munger (amunger)
enabled auto-merge (squash)
May 21, 2024 20:13
Anthony Kim (anthonykim1)
approved these changes
May 21, 2024
| throw new Error(`scheme '${scheme}' already registered`); | ||
| } | ||
|
|
||
| this._logService.warn('TEST WARNING'); |
Contributor
There was a problem hiding this comment.
should this be removed?
Collaborator
Author
There was a problem hiding this comment.
whoops, yes
mustard (mustard-mh)
pushed a commit
to gitpod-io/openvscode-server
that referenced
this pull request
May 22, 2024
* added trace logs * another trace message * fix test ctors
André Silva (andremmsilva)
pushed a commit
to PIC1G55/vscodeG55
that referenced
this pull request
May 26, 2024
* added trace logs * another trace message * fix test ctors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some trace logs to help troubleshoot saving issues and also more detail in the error telemetry to know more about the error type frequency.
microsoft/vscode-jupyter#15698