increase listener refusal threshold significantly - #213292
Merged
Merged
Conversation
Benjamin Pasero (bpasero)
previously approved these changes
May 23, 2024
Benjamin Pasero (bpasero)
left a comment
Benjamin Pasero (bpasero)
left a comment
Contributor
There was a problem hiding this comment.
👍 , this means we can probably remove some / all of the custom overrides.
Contributor
Author
I don't think so. We still emit warnings and report errors for potential listener leaks but this PR means listener refusal (the last resort before freezing) happens much later |
Martin Aeschlimann (aeschli)
approved these changes
May 23, 2024
André Silva (andremmsilva)
pushed a commit
to PIC1G55/vscodeG55
that referenced
this pull request
May 26, 2024
* increase listener refusal threshold significantly * fix tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.