fix: remove temp dir if extension is installed by another source - #213379
Merged
Sandeep Somavarapu (sandy081) merged 1 commit intoMay 29, 2024
Merged
Conversation
Sandeep Somavarapu (sandy081)
approved these changes
May 29, 2024
Sandeep Somavarapu (sandy081)
enabled auto-merge (squash)
May 29, 2024 12:17
Benjamin Pasero (bpasero)
approved these changes
May 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In current implementation, if an extension was installed by another source, then the extracted temp folder would not be deleted, causing lots of temporary folders left on my machine.
This PR fixed this issue by removing the temp directory on
ENOTEMPTY.