Repository navigation
chore: bump node-pty@1.1.0-beta35 - #267939
Merged
Merged
Conversation
Robo (deepak1556)
marked this pull request as ready for review
September 23, 2025 12:01
Robo (deepak1556)
enabled auto-merge (squash)
September 23, 2025 12:01
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the node-pty dependency from version 1.1.0-beta33 to 1.1.0-beta35 across the VS Code codebase. The update is related to upstream changes in the node-pty repository as referenced in PR #801.
Key changes:
- Bumps node-pty dependency version in both main and remote package configurations
- Removes the caret (^) prefix from the version specification, pinning to the exact beta version
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updates node-pty dependency to exact version 1.1.0-beta35 |
| remote/package.json | Updates node-pty dependency to exact version 1.1.0-beta35 for remote scenarios |
Files not reviewed (1)
- remote/package-lock.json: Language not supported
Ladislau Szomoru (lszomoru)
approved these changes
Sep 23, 2025
Contributor
|
Robo (@deepak1556) You should also add node-gyp as devDependencies, because npx --offline node-gyp need it to realize lock node-gyp used for compile commands. |
Contributor
|
I create a PR to do this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For microsoft/node-pty#801