Skip to content

Enable Windows Conpty Dll as default - #315951

Merged
Anthony Kim (anthonykim1) merged 1 commit into
mainfrom
anthonykim1/conPtyDefault
May 12, 2026
Merged

Anthony Kim (anthonykim1) merged 1 commit into
mainfrom
anthonykim1/conPtyDefault

Conversation

@anthonykim1

Copy link
Copy Markdown
Contributor

@anthonykim1 Anthony Kim (anthonykim1) added this to the 1.121.0 milestone May 12, 2026
Copilot AI review requested due to automatic review settings May 12, 2026 05:10
@anthonykim1
Anthony Kim (anthonykim1) marked this pull request as ready for review May 12, 2026 05:11
@anthonykim1
Anthony Kim (anthonykim1) enabled auto-merge (squash) May 12, 2026 05:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR flips the default for the Windows terminal setting terminal.integrated.windowsUseConptyDll so VS Code uses the bundled conpty.dll by default, aligning with the goal of shipping a newer ConPTY implementation rather than relying on the OS-provided one.

Changes:

  • Set terminal.integrated.windowsUseConptyDll default to true.
  • Remove “preview/experimental” labeling from the setting description/metadata.
Show a summary per file
File Description
src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts Makes the shipped conpty.dll the default backend option by updating the setting schema (description + default).

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment thread src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts
@anthonykim1
Anthony Kim (anthonykim1) merged commit cfebe6a into main May 12, 2026
29 checks passed
@anthonykim1
Anthony Kim (anthonykim1) deleted the anthonykim1/conPtyDefault branch May 12, 2026 05:32

@Tyriar Daniel Imms (Tyriar) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did the rollout for this look? Has it been in stable for some time?

@anthonykim1

Copy link
Copy Markdown
Contributor Author

Daniel Imms (@Tyriar) Thankfully not much surprised as initially thought! This has been sitting on stable for 100% for at least 3 weeks~

Only thing that was odd was #311821 , long standing psreadline issue where it would request "black" when they mean "no background"
tl;dr is to just update psreadline or just use powershell that is not decade old..

@vs-code-engineering vs-code-engineering Bot locked and limited conversation to collaborators Jun 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ship newer version of conpty

4 participants