Skip to content

Add execution level to telemetry summary and logs #6195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnMcPMS merged 1 commit into from
May 7, 2026
Merged

Add execution level to telemetry summary and logs #6195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/AppInstallerCommonCore/AppInstallerTelemetry.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,16 @@ namespace AppInstaller::Logging
packageVersion = Runtime::GetPackageVersion();
}

ExecutionLevel executionLevel = ExecutionLevel::User;
if (Runtime::IsRunningAsSystem())
{
executionLevel = ExecutionLevel::System;
}
else if (Runtime::IsRunningAsAdmin())
{
executionLevel = ExecutionLevel::Admin;
}

if (IsTelemetryEnabled())
{
AICLI_TraceLoggingWriteActivity(
Expand All @@ -250,11 +260,12 @@ namespace AppInstaller::Logging
if (m_useSummary)
{
m_summary.IsCOMCall = isCOMCall;
m_summary.ExecutionLevel = executionLevel;
}
}

AICLI_LOG(Core, Info, << "WinGet, version [" << version << "], activity [" << *GetActivityId() << ']');
AICLI_LOG(Core, Info, << "Process: " << Filesystem::GetExecutablePathForProcess(GetCurrentProcess()).filename() << "[" << GetCurrentProcessId() << "], Offset: " << &__ImageBase);
AICLI_LOG(Core, Info, << "Process: " << Filesystem::GetExecutablePathForProcess(GetCurrentProcess()).filename() << "[" << GetCurrentProcessId() << "], Level[" << executionLevel << "], Offset: " << &__ImageBase);
AICLI_LOG(Core, Info, << "OS: " << Runtime::GetOSVersion());
AICLI_LOG(Core, Info, << "Command line Args: " << Utility::ConvertToUTF8(GetCommandLineW()));
if (Runtime::IsRunningInPackagedContext())
Expand Down Expand Up @@ -867,6 +878,7 @@ namespace AppInstaller::Logging
AICLI_TraceLoggingStringView(m_summary.FailureFile, "FailureFile"),
TraceLoggingUInt32(m_summary.FailureLine, "FailureLine"),
TraceLoggingBool(m_summary.IsCOMCall, "IsCOMCall"),
TraceLoggingUInt32(static_cast<UINT32>(m_summary.ExecutionLevel), "ExecutionLevel"),
AICLI_TraceLoggingStringView(m_summary.Command, "Command"),
TraceLoggingBool(m_summary.CommandSuccess, "CommandSuccess"),
TraceLoggingBool(m_summary.IsManifestLocal, "IsManifestLocal"),
Expand Down
8 changes: 8 additions & 0 deletions src/AppInstallerCommonCore/Public/AppInstallerTelemetry.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,13 @@ namespace AppInstaller::Settings

namespace AppInstaller::Logging
{
enum class ExecutionLevel : UINT32
{
User = 0,
Admin = 1,
System = 2,
};

enum class FailureTypeEnum : UINT32
{
None = 0x0,
Expand Down Expand Up @@ -61,6 +68,7 @@ namespace AppInstaller::Logging

// LogStartup
bool IsCOMCall = false;
ExecutionLevel ExecutionLevel = ExecutionLevel::User;

@yao-msft yao-msft May 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment says LogStartup but it's only logged to summary?

@JohnMcPMS JohnMcPMS May 7, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it is initialized and logged in the LogStartup function. I didn't want to update a critical event for multiple reasons.


// LogCommand
std::string Command;
Expand Down
Loading