Implement uninstall flow

[florelis]

This is in progress and does not work completely yet. I'm opening it as a draft to see if there are any major issues.

Changes:

• Added an UninstallCommand as an experimental feature.
• Added workflow tests for uninstall (not passing yet).
• Added uninstall WorkflowTasks for uninstalling MSIX/MSStore apps with the package name, and everything else with the uninstall string. This uses already existing information form manifests/ARP.

Still missing:

• Logging, reporting, telemetry
• E2E tests
• More manual validation to work out details/edge cases

Related: #121 #397

Microsoft Reviewers: Open in CodeFlow

[github-actions]

New misspellings found, please review:

• fca
• insalled
• kzf
• qxf
• Skype
• skypeapp
• STARTUPINFOW
• uninstallation
• wcsdup
• zg

To accept these changes, run the following commands

perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"AComment addressof ALIGNAS allescaped alse ARMEL backend bitfield blep BORLAND cassert cctype cdunn cerr clocale CMake cmath cname codepoint cplusplus CPPLIB cstddef cstdio cstdlib cstr cstring CStyle ctor czstring deque deref dllimport dnp elif emark endcode endverbatim EOL eturn eyc fpclassify gcc GNUC hpux HREF hrow ieeefp inl iosfwd isfinite Isfinitef isnan isprint IString javascript jsonvalue keey keylength lconv len Lepilleur localeconv lossfree malloc maxsize memcmp memcpy memset MINGW modf msvc Multiline mutators nfinity noreturn NULLREF nvcc NVIDIAs OString ote ptrdiff py Solaris sourceforge sout SOVERSION ssin stackoverflow stdarg strchr strcmp strdup strlen strncmp unindent Unserialize usf valueiterator vscprintf vsnprintf walkaround wiki wikipedia Workaround xf xl "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^($re)(?:$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"fca insalled kzf qxf Skype skypeapp STARTUPINFOW uninstallation wcsdup zg "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
git add .github/actions/spelling || echo '... you want to ensure .github/actions/spelling/expect.txt is added to your repository...'

#Closed

[github-actions]

New misspellings found, please review:

• fca
• insalled
• INSTALLLEVEL
• INSTALLSTATE
• INSTALLUILEVEL
• kzf
• qxf
• Skype
• skypeapp
• STARTUPINFOW
• uninstallation
• zg

To accept these changes, run the following commands

perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"AComment addressof ALIGNAS allescaped alse ARMEL backend bitfield blep BORLAND cassert cctype cdunn cerr clocale CMake cmath cname codepoint cplusplus CPPLIB cstddef cstdio cstdlib cstr cstring CStyle ctor czstring deque deref dllimport dnp elif emark endcode endverbatim EOL eturn eyc fpclassify gcc GNUC hpux HREF hrow ieeefp inl iosfwd isfinite Isfinitef isnan isprint IString javascript jsonvalue keey keylength lconv len Lepilleur localeconv lossfree malloc maxsize memcmp memcpy memset MINGW modf msvc Multiline mutators nfinity noreturn NULLREF nvcc NVIDIAs OString ote ptrdiff py Solaris sourceforge sout SOVERSION ssin stackoverflow stdarg strchr strcmp strdup strlen strncmp unindent Unserialize usf valueiterator vscprintf vsnprintf walkaround wiki wikipedia Workaround xf xl "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^($re)(?:$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"fca insalled INSTALLLEVEL INSTALLSTATE INSTALLUILEVEL kzf qxf Skype skypeapp STARTUPINFOW uninstallation zg "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
git add .github/actions/spelling || echo '... you want to ensure .github/actions/spelling/expect.txt is added to your repository...'

#Closed

[github-actions]

New misspellings found, please review:

• fca
• INET
• kzf
• qxf
• zg

To accept these changes, run the following commands

perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"AComment addressof ALIGNAS allescaped alse ARMEL backend bitfield blep BORLAND cassert cctype cdunn cerr clocale CMake cmath cname codepoint cplusplus CPPLIB cstddef cstdio cstdlib cstr cstring CStyle ctor czstring deque deref dllimport dnp elif emark endcode endverbatim EOL eturn eyc fpclassify gcc GNUC hpux HREF hrow ieeefp inl iosfwd isfinite Isfinitef isnan isprint IString javascript jsonvalue keey keylength lconv len Lepilleur localeconv lossfree malloc maxsize memcmp memcpy memset MINGW modf msvc Multiline mutators nfinity noreturn NULLREF nvcc NVIDIAs OString ote ptrdiff py Skype Solaris sourceforge sout SOVERSION ssin stackoverflow stdarg strchr strcmp strdup strlen strncmp unindent Unserialize usf valueiterator vscprintf vsnprintf walkaround wiki wikipedia Workaround xf xl "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^($re)(?:$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"fca INET kzf qxf zg "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
git add .github/actions/spelling || echo '... you want to ensure .github/actions/spelling/expect.txt is added to your repository...'

#Closed

[JohnMcPMS]

(uninstallResult.value() != 0) [](start = 16, length = 30)

This may need to be smarter; at a minimum I would expect a lot of "reboot required" errors coming out. I think that for at least MSI we should probably figure out what can come back from msiexec.exe and be able to handle those values.

[florelis]

I'm leaving this as a TODO for now as I'm not entirely sure what's the right thing to do with other exit codes. I'm trying to find an application that returns something non-zero to see what it does and how it is handled when uninstalling with Porgrams and Features or the Settings app. I'll probably add a telemetry point for errors that will help here.

[yao-msft]

/azp run #Closed

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[yao-msft]

        productCodeStream << argv[i];

I know it's not your fault but probably a previous unaddressed comment. This should just be std::string productCode; (not std::wstring) declaration in line 131 and direct assignment here.

In line 131,
std::string produceCode;

And here:
productCode = argv[i]; #Closed

---

Refers to: src/AppInstallerTestExeInstaller/main.cpp:151 in 1181019. [](commit_id = 1181019, deletion_comment = False)

[azure-pipelines]

No pipelines are associated with this pull request.

[yao-msft]