Skip to content

Bring valijson as subtree#697

Merged
yao-msft merged 3 commits into
microsoft:masterfrom
yao-msft:valijsonsubtree
Jan 12, 2021
Merged

Bring valijson as subtree#697
yao-msft merged 3 commits into
microsoft:masterfrom
yao-msft:valijsonsubtree

Conversation

@yao-msft

@yao-msft yao-msft commented Jan 12, 2021

Copy link
Copy Markdown
Contributor

Change

Using command:

git subtree add --prefix=src/Valijson/valijson https://github.com/tristanpenman/valijson.git v0.3 --squash
Microsoft Reviewers: Open in CodeFlow

git-subtree-dir: src/Valijson/valijson
git-subtree-split: 7a52fc88cdffd6678c009ca2fad700151f7363c6
@yao-msft yao-msft requested a review from a team as a code owner January 12, 2021 03:00
@jsoref

jsoref commented Jan 12, 2021

Copy link
Copy Markdown
Contributor

@yao-msft: add:

^src/Valijson/valijson/

to .github/actions/spelling/excludes.txt

n.b. I suspect that Inputt is a typo. But I'll have to visit the upstream at a later date.

@yao-msft

Copy link
Copy Markdown
Contributor Author

@yao-msft: add:

^src/Valijson/valijson/

to .github/actions/spelling/excludes.txt

n.b. I suspect that Inputt is a typo. But I'll have to visit the upstream at a later date.

Yes, thanks.

@JohnMcPMS

JohnMcPMS commented Jan 12, 2021

Copy link
Copy Markdown
Member

You will need to update cgmanifest.json as well. Also remember that we will need to merge, not squash, if we want to preserve the subtree. So you will probably want to merge all other commits into a single a force push to your fork.

Also ensure that this license is acceptable. #Resolved

@yao-msft yao-msft merged commit bd64384 into microsoft:master Jan 12, 2021
@yao-msft yao-msft deleted the valijsonsubtree branch January 12, 2021 23:20
@jedieaston jedieaston mentioned this pull request Nov 17, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants