Skip to content

Azure pipeline to generate and publish Microsoft.WindowsPackageManager.Utils nuget package#741

Merged
palenshus merged 26 commits into
microsoft:masterfrom
palenshus:master
Feb 8, 2021
Merged

Azure pipeline to generate and publish Microsoft.WindowsPackageManager.Utils nuget package#741
palenshus merged 26 commits into
microsoft:masterfrom
palenshus:master

Conversation

@palenshus

@palenshus palenshus commented Feb 3, 2021

Copy link
Copy Markdown
Contributor
  • Adding nuspec for the package
  • Updating Update-BinVer.ps1 to allow passing in the major/minor version instead of getting from release tag
  • Creating new build pipeline which takes a major/minor version as a parameter, updates the version in source and builds and signs, generates a nuget package and signs that, then publishes it

I haven't tested the actual push command yet, as I'd like to get PR approval before doing so

Microsoft Reviewers: Open in CodeFlow

@palenshus palenshus requested a review from a team as a code owner February 3, 2021 23:02
@github-actions

github-actions Bot commented Feb 3, 2021

Copy link
Copy Markdown

New misspellings found, please review:

  • ative
  • esrp
  • gtm
  • Minimatch
  • NPH
  • nupkg
  • nuspec
  • Params
  • Peet
  • rfc
  • runtimes
  • SFP
  • td
To accept these changes, run the following commands
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"AComment addressof ALIGNAS allescaped alse ARMEL backend bbwe bitfield blep BORLAND cassert cctype cdunn cerr clocale CMake cmath cname codepoint cplusplus CPPLIB cstddef cstdio cstdlib cstr cstring CStyle ctor czstring deque deref dllimport dnp elif emark endcode endverbatim EOL eturn eyc fpclassify gcc GNUC hpux HREF hrow ieeefp inl iosfwd isfinite Isfinitef isnan isprint IString javascript jsonvalue keey keylength lconv len Lepilleur localeconv lossfree malloc maxsize memcmp memset MINGW modf msvc Multiline mutators nfinity noreturn NULLREF nvcc NVIDIAs OString ote ptrdiff py Skype skypeapp Solaris sourceforge sout SOVERSION ssin stackoverflow STARTUPINFOW stdarg strchr strcmp strdup strlen strncmp unindent Unserialize usf valueiterator vscprintf vsnprintf walkaround wiki wikipedia Workaround wstringstream xf xl "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^($re)(?:$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"ative esrp gtm Minimatch NPH nupkg nuspec Params Peet rfc runtimes SFP td "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
git add .github/actions/spelling || echo '... you want to ensure .github/actions/spelling/expect.txt is added to your repository...'

@jsoref

jsoref commented Feb 3, 2021

Copy link
Copy Markdown
Contributor

For ative, you probably want to add a pattern.

Possibilities include:
\\native
target="[^"]*"

Comment thread WinGetUtil.nuspec Outdated
Comment thread azure-pipelines.nuget.yml
Comment thread azure-pipelines.nuget.yml Outdated
Comment thread azure-pipelines.yml Outdated
@github-actions

github-actions Bot commented Feb 4, 2021

Copy link
Copy Markdown

New misspellings found, please review:

  • ative
  • esrp
  • gtm
  • Minimatch
  • NPH
  • nupkg
  • nuspec
  • Params
  • rfc
  • runtimes
  • SFP
  • td
To accept these changes, run the following commands
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"AComment addressof ALIGNAS allescaped alse ARMEL backend bbwe bitfield blep BORLAND cassert cctype cdunn cerr clocale CMake cmath cname codepoint cplusplus CPPLIB cstddef cstdio cstdlib cstr cstring CStyle ctor czstring deque deref dllimport dnp elif emark endcode endverbatim EOL eturn eyc fpclassify gcc GNUC hpux HREF hrow ieeefp inl iosfwd isfinite Isfinitef isnan isprint IString javascript jsonvalue keey keylength lconv len Lepilleur localeconv lossfree malloc maxsize memcmp memset MINGW modf msvc Multiline mutators nfinity noreturn NULLREF nvcc NVIDIAs OString ote ptrdiff py Skype skypeapp Solaris sourceforge sout SOVERSION ssin stackoverflow STARTUPINFOW stdarg strchr strcmp strdup strlen strncmp unindent Unserialize usf valueiterator vscprintf vsnprintf walkaround wiki wikipedia Workaround wstringstream xf xl "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^($re)(?:$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"ative esrp gtm Minimatch NPH nupkg nuspec Params rfc runtimes SFP td "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
git add .github/actions/spelling || echo '... you want to ensure .github/actions/spelling/expect.txt is added to your repository...'

@JohnMcPMS JohnMcPMS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a minor change requested.

Comment thread azure-pipelines.nuget.yml Outdated
Comment thread azure-pipelines.nuget.yml
@jsoref

jsoref commented Feb 4, 2021

Copy link
Copy Markdown
Contributor

I'm pretty sure right now that the bot is still upset with you.

I'm going to make a PR this weekend to make that more visible (upgrading the bot to the latest release).

@github-actions

github-actions Bot commented Feb 4, 2021

Copy link
Copy Markdown

New misspellings found, please review:

  • ative
  • esrp
  • gtm
  • Minimatch
  • NPH
  • nupkg
  • nuspec
  • Params
  • rfc
  • runtimes
  • SFP
  • td
To accept these changes, run the following commands
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"AComment addressof ALIGNAS allescaped alse ARMEL backend bbwe bitfield blep BORLAND cassert cctype cdunn cerr clocale CMake cmath cname codepoint cplusplus CPPLIB cstddef cstdio cstdlib cstr cstring CStyle ctor czstring deque deref dllimport dnp elif emark endcode endverbatim EOL eturn eyc fpclassify gcc GNUC hpux HREF hrow ieeefp inl iosfwd isfinite Isfinitef isnan isprint IString javascript jsonvalue keey keylength lconv len Lepilleur localeconv lossfree malloc maxsize memcmp memset MINGW modf msvc Multiline mutators nfinity noreturn NULLREF nvcc NVIDIAs OString ote ptrdiff py Skype skypeapp Solaris sourceforge sout SOVERSION ssin stackoverflow STARTUPINFOW stdarg strchr strcmp strdup strlen strncmp unindent Unserialize usf valueiterator vscprintf vsnprintf walkaround wiki wikipedia Workaround wstringstream xf xl "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^($re)(?:$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"ative esrp gtm Minimatch NPH nupkg nuspec Params rfc runtimes SFP td "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
git add .github/actions/spelling || echo '... you want to ensure .github/actions/spelling/expect.txt is added to your repository...'

@github-actions

github-actions Bot commented Feb 4, 2021

Copy link
Copy Markdown

New misspellings found, please review:

  • cvd
  • fileio
  • nblggh
  • necho
  • nns
  • NPH
  • opencod
  • pacity
  • pgp
  • restrictedcapabilities
  • secur
  • technet
  • xa
To accept these changes, run the following commands
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"AComment addressof ALIGNAS allescaped alse ARMEL backend bbwe bitfield blep blogs BORLAND cassert cctype cdunn centralus cerr clocale cloudapp CMake cmath cname codepoint contosa contosainstaller cplusplus CPPLIB cstddef cstdio cstdlib cstr cstring CStyle ctor czstring deque deref dllimport dnp elif emark endcode endverbatim EOL eturn eyc foldc fpclassify gcc GNUC google hpux HREF hrow ieeefp inl iosfwd isfinite Isfinitef isnan isprint IString javascript jsonvalue keey keylength lconv len Lepilleur llvm localeconv lossfree malloc maxsize memcmp memset MINGW modf msvc Multiline mutators myinstalldir mysilentwithprogress nfinity noreturn NULLREF nvcc NVIDIAs oss OString ote ptrdiff pwabuilder py qb schematab Skype skypeapp Solaris sourceforge sout SOVERSION ssin stackoverflow STARTUPINFOW stdarg strchr strcmp strdup strlen strncmp unindent Unserialize usf valueiterator vscprintf vsnprintf walkaround wiki wikipedia windir windowsdeveloper Workaround wstringstream xf xl "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^($re)(?:$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"cvd fileio LLVM nblggh necho nns NPH opencod pacity pgp restrictedcapabilities secur technet xa "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
git add .github/actions/spelling || echo '... you want to ensure .github/actions/spelling/expect.txt is added to your repository...'

@jsoref jsoref left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously it's up to the project, but I wouldn't do this.

Comment thread .github/actions/spelling/patterns.txt Outdated
Comment thread .github/actions/spelling/patterns.txt Outdated
@palenshus

Copy link
Copy Markdown
Contributor Author

@jsoref is there a way I can run the spelling checker tool locally so I don't have to keep bombarding the PR with iterations while I troubleshoot this?

@github-actions

github-actions Bot commented Feb 8, 2021

Copy link
Copy Markdown

Misspellings found, please review:

  • applicatio
  • NPH
  • opencod
  • pacity
  • secur
  • technet
To accept these changes, run the following commands from this repository on this branch
pushd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"blogs centralus cloudapp contosa contosainstaller google llvm oss pwabuilder schematab windowsdeveloper "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
make_path ".github/actions/spelling";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"applicatio LLVM NPH opencod pacity secur technet "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

@jsoref

jsoref commented Feb 8, 2021

Copy link
Copy Markdown
Contributor

@palenshus: if you enable actions in your fork, a push to any branch (not just one associated with a PR) will trigger the action.

@palenshus palenshus merged commit 2a6095c into microsoft:master Feb 8, 2021
@jsoref

jsoref commented Feb 8, 2021

Copy link
Copy Markdown
Contributor

@palenshus: there's an optional advice file that one could add which could help people learn to do that.

(At some point I'll probably collate some of this advice into the defaults... I'm still collecting feedback.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants