Better error message for manifest input validation errors#812
Merged
Conversation
yao-msft
force-pushed
the
user/yaosun/bettererrormsg
branch
from
a32f3de to
f04d86f
Compare
JohnMcPMS
approved these changes
Mar 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the manifest input validation code does not check required fields existence before using them to determine manifest consistency. This will result in unhelpful error message saying "Expected node type does not match". This change checks those fields before using them to give a better error message for winget validate commands.
Also removed the format uri restriction per Union's ask.
Microsoft Reviewers: Open in CodeFlow