Rest endpoint helper and json object field check - Bug fix#821
Merged
Conversation
ashpatil-msft
changed the title
JohnMcPMS
approved these changes
Mar 26, 2021
JohnMcPMS
left a comment
JohnMcPMS
left a comment
Member
There was a problem hiding this comment.
So we obviously need tests eventually, and I think we do need to do the http client injection for the unit tests so that we can easily test the corner cases.
| namespace AppInstaller::Repository::Rest::Schema | ||
| { | ||
| // Rest source helper. | ||
| struct RestHelper |
Member
There was a problem hiding this comment.
You don't have to put every function inside a class type.
sreadingMSFT
added a commit
to sreadingMSFT/winget-cli
that referenced
this pull request
Mar 26, 2021
Rest endpoint helper and json object field check - Bug fix (microsoft#821)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed two bugs in the Rest source code:
Manually tested and verified basic install and manifest deserialization.
Microsoft Reviewers: Open in CodeFlow