Repository navigation
Recent dependency bumps causes MsalUiRequiredException, breaks functionality #129
Description
Describe the bug
The version bumps in the following packages seem to have breaking changes unaccounted for in this repo (I'm not familiar enough to understand what, exactly):
- Microsoft.Identity.Web
- Microsoft.Identity.Web.MicrosoftGraph
- Microsoft.Identity.Web.Ui
Maybe it's something with our Azure App but I consistently get the following exceptions when signing in, and the site is broken after that:
MsalUiRequiredException:
ErrorCode: user_null
Microsoft.Identity.Client.MsalUiRequiredException: No account or login hint was passed to the AcquireTokenSilent call.
To Reproduce
Steps to reproduce the behavior:
- Make sure you've signed out of the application or use private browser
- Checkout 7aeeb9a (HEAD at main branch at time of writing)
- Try to sign in
- Site is broken:
- Dropdown menu in upper right is incomplete
- Welcome message for user on home page missing
TimeZoneNotSupportedExceptiondisplayed in calendar (screenshot below)
Expected behavior
Checking out 9b6b9c9 (prior to the version bumps above) seems to solve the issue. I can sign in and view my calendar events. No issues
Screenshots
Desktop (please complete the following information):
- OS: Windows 11
- Browser: Edge
- Version: 117.0.2045.60
Activity
jasonjoh commentedon Oct 11, 2023
Thanks for reporting this Luke Westfall (@lwestfall)! I reproduce this as well. It seems with the release of 2.15.1 for the Microsoft.Identity.Web dependencies, they introduced a bug that impacts custom
OnTokenValidatedhandlers, like the one we use in this sample to add Graph information to the claims principal. I believe this is causing the failure.For now, I would keep all three Microsoft.Identity.Web dependencies (Microsoft.Identity.Web, Microsoft.Identity.Web.UI, and Microsoft.Identity.Web.MicrosoftGraph) at 2.14.0 until a fix is released.
lwestfall commentedon Oct 11, 2023
Jason Johnston (@jasonjoh) thanks for the quick response and for validating my sanity!
crazycga commentedon Oct 17, 2023
Man, do I feel dumb. I'll close my ticket and show myself out. Thanks Jason Johnston (@jasonjoh) .
jasonjoh commentedon Oct 23, 2023
Luke Westfall (@lwestfall) crazycga Looks like the issue has been resolved in the 2.15.3 versions of the Microsoft.Identity.Web* libraries.