Conversation
altonen
requested review from
TheQuantumPhysicist,
b-yap,
iljakuklic,
muursh,
sinitcin and
zorvan
January 10, 2022 11:49
Contributor
Author
|
I prefer the |
Contributor
|
No RwLock please. Even if we're accepting lazy static, we should just use an atomic i64, where zero means not set, and other values is set. RwLock is a huge performance hit. |
Contributor
Author
|
I'm not 100% sure but I think either an |
Contributor
Author
|
I was wrong. If we don't use the |
TheQuantumPhysicist
approved these changes
Jan 11, 2022
Additionally, convert P2P to use i64 instead of u64 for the timestamp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides three different example implementations for custom time source:
lazy_static!implementation that all systems use and time is queried and modified usingcommon::primitives::time::get()/set()Arc<RwLock<Time>>object that is created inmain.rsand then passed on as reference to subsystemsTimeobject where subsystems modify each other's time by issuing a system command (how that's exactly done is TBD and probably outside the scope of this PR)Let me know what you think. When we've decided on something, I'll convert this to a proper PR.