feat/common/uint256_and_compact - #64
Merged
Merged
Conversation
b-yap
requested review from
TheQuantumPhysicist,
iljakuklic,
muursh,
royster57,
sinitcin and
zorvan
January 14, 2022 08:38
|
|
||
| impl Compact { | ||
| // https://github.com/bitcoin/bitcoin/blob/7fcf53f7b4524572d1d0c9a5fdc388e87eb02416/src/arith_uint256.cpp#L203 | ||
| pub fn into_uint256(self) -> Option<Uint256> { |
Contributor
There was a problem hiding this comment.
How about try_from for this?
| @@ -0,0 +1,156 @@ | |||
| // Rust Bitcoin Library | |||
Contributor
There was a problem hiding this comment.
It seems like the util directory is exclusively used for the uint.rs stuff. Can we move these to their own directory under uint and expose them?
TheQuantumPhysicist
approved these changes
Jan 14, 2022
TheQuantumPhysicist
left a comment
TheQuantumPhysicist
left a comment
Contributor
There was a problem hiding this comment.
Other than the few comments I made, it seems fine.
rename util directory to uint; move the uint file to the uint directory; ran clippy. for compact to uint256, `TryFrom` is implemented
muursh
approved these changes
Jan 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
address comments about compact:
#62 (comment)
#62 (comment)
Because the # of files to review in my other PRs are getting larger, it's best to separate these in another PR.