Repository navigation
enhance(frontend): 複雑なCSSアニメーションをWeb Animations APIに置き換え - #18152
Draft
kakkokari-gtyih wants to merge 1 commit into
Draft
kakkokari-gtyih wants to merge 1 commit into
kakkokari-gtyih wants to merge 1 commit into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #18152 +/- ##
===========================================
+ Coverage 12.81% 12.82% +0.01%
===========================================
Files 228 228
Lines 11181 11179 -2
Branches 3699 3701 +2
===========================================
+ Hits 1433 1434 +1
+ Misses 7661 7656 -5
- Partials 2087 2089 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
🖥 Frontend Diagnostics Report(No significant changes) Requests by resource type
V8 heap snapshot statistics
📦 Bundle StatsChunk size diff (2 updated, 0 added, 0 removed)
Startup chunk size (1 updated, 0 added, 0 removed)
Startup chunks are the Vite entry for
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
CSSアニメーションを何とかして使っているような部分を、Web Animations APIに変更してプログラマブルにアニメーションできるように
transitionend待ち、requestAnimationFrame、transitionの一時無効化)をやめ、前の角度から時計回りに進めるanimate()に置き換えtransition: 0sのクラス切り替えとsetTimeout(30ms)から、秒が変わるたびのanimate()再生に置き換えsetTimeout(1ms後に開始、1000ms後に透明化、2000ms後に削除)をanimate()にまとめ、finishedでDOMから削除するように変更setTimeout(10ms)による開始とsetTimeout(1100ms)による終了を廃止し、ランダム角度をv-bind()ではなくキーフレームへ直接渡して、finishedでendを発火するようにsetTimeoutによる開始・終了とv-bind()の角度をanimate()とfinishedに置き換えinfiniteなアニメーションをdur - 100msで削除する処理を廃止し、粒子ごとに1回だけ再生してfinishedで削除setTimeout(1ms)でtransitionを起こしてインラインstyleを残す方式から、要素本来のスタイルへ戻るanimate()に変更animationendから click 時のanimate()に変更(子要素からバブリングしてきた
animationendでバウンスが途中で止まる不具合も解消)Why
setTimeoutによるアニメーション制御を解消するため(パフォーマンス向上)Additional info (optional)
Checklist