Rename confusion breaks data contract serialization #147

Activity

1. mkaring

   added

   bugSomething isn't workingSomething isn't working

   on Jun 2, 2020
2. mkaring commented on Jun 2, 2020

   

   mkaring

   on Jun 2, 2020

   Owner

   More actions

   You are correct. What happens here is clearly wrong. Renaming the members is correct, because you are obfuscating an executable and ConfuserEx treats all the types in an executable as internal. However, you did set the DataMember, and that should keep the naming in the serialized output the same.

   There are a couple of issues surrounding properties and attributes on properties that were found in issue #123. This issue may be related to one of them.
3. mkaring

   added this to the 1.4 milestone on Jun 2, 2020
4. semenenkov commented on Jun 2, 2020

   

   semenenkov

   on Jun 2, 2020

   Last edited by semenenkov

   Author

   More actions

   @mkaring thanks for reply,
   you are obfuscating an executable and ConfuserEx treats all the types in an executable as internal
   I think this is arguable but from some point of view make sense.
   From the point of normal human logic - yes, but from the point of .net it is still an assembly and its public members in theory can be requested from outside. I think some old confuser versions did not rename public members and I was relying on that, making logic-sensitive members internal and others, especially performance-sensitive or confuser-buggy - public. I don't mind of this new approach, just will have to change my habits and some code to use [Obfuscation] attribute instead of public access modifier.
5. mkaring commented on Jun 2, 2020

   

   mkaring

   on Jun 2, 2020

   Owner

   More actions

   ConfuerEx always handled the types in executables like this. Not sure what the old Confuser did.

   There is a way however, to enforce that the public members remain untouched. You have to add the renPublic parameter of the rename protection with the value false. This way you can disable the automatic selection of this parameter based on the assembly type.

   <project outputDir=".\Confused" baseDir="." xmlns="http://confuser.codeplex.com">
     <rule pattern="true" inherit="false">
       <protection id="rename">
         <argument name="renPublic" value="false" />
       </protection>
     </rule>
     <module path="WpfApp1.exe" />
   </project>
6. semenenkov commented on Jun 2, 2020

   

   semenenkov

   on Jun 2, 2020

   Author

   More actions

   @mkaring thanks a lot for the tip!
   Previous version I am still using was released many years ago, it is even not Ex yet, and I am pretty sure public members were not confused, I can't check it with disassembler but I see it from exception stack traces.
7. mkaring

   added

   enhancementNew feature or requestNew feature or request

   on Jul 1, 2020
8. mkaring

   removed this from the 1.4 milestone on Jul 1, 2020
9. mcpolo99

   added 2 commits that reference this issue on Jun 7, 2026

   fix(renamer): skip renaming of DataContract/DataMember/JsonProperty a…

   ...

   49b365f

   Pre release (#68)

   ...

   1a81d79