Skip to content

feat: ✨ create macmon class for Mac monitoring - #752

Open
LuisBlanche wants to merge 21 commits into
masterfrom
731-sudoless-power-metrics-on-apple-silicon
Open

feat: ✨ create macmon class for Mac monitoring#752
LuisBlanche wants to merge 21 commits into
masterfrom
731-sudoless-power-metrics-on-apple-silicon

Conversation

@LuisBlanche

@LuisBlanche LuisBlanche commented Dec 20, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

fixes #731

@LuisBlanche LuisBlanche linked an issue Dec 20, 2024 that may be closed by this pull request
Sudoless power metrics on Apple Silicon #731
Open
@LuisBlanche LuisBlanche self-assigned this Dec 20, 2024
@LuisBlanche
LuisBlanche marked this pull request as ready for review December 21, 2024 11:25
@LuisBlanche

LuisBlanche commented Dec 21, 2024

Copy link
Copy Markdown
Contributor Author

Need to update the docs to add macmon installation

benoit-cty
benoit-cty reviewed Dec 22, 2024
View reviewed changes
Comment thread codecarbon/core/resource_tracker.py Resolved
@LuisBlanche LuisBlanche mentioned this pull request Jan 17, 2025
Closed
@LuisBlanche

LuisBlanche commented Jan 19, 2025

Copy link
Copy Markdown
Contributor Author

Waiting for vladkens/macmon#20 answer to see if there is something wrong with ram_power measurement

@LuisBlanche LuisBlanche added the enhancement New feature or request label Feb 8, 2025
@KennethEnevoldsen

KennethEnevoldsen commented Mar 13, 2025

Copy link
Copy Markdown

HI @LuisBlanche any update on this one - we would love to have it over on MTEB

@LuisBlanche

LuisBlanche commented Mar 13, 2025

Copy link
Copy Markdown
Contributor Author

We have an issue where RAM power is not correctly measured by macmon on M1 chips. I am currently discussing this with the maintainer. I can probably adapt the code so that it does not use macmon for RAM with M1

@KennethEnevoldsen

KennethEnevoldsen commented Mar 13, 2025

Copy link
Copy Markdown

Alright, no stress just wanted to to know whether it had gotten stale

@ElliottKasoar ElliottKasoar mentioned this pull request Mar 25, 2025
Merged
@LuisBlanche

LuisBlanche commented Apr 19, 2025

Copy link
Copy Markdown
Contributor Author

@benoit-cty I have updated this and I think it is ready to merge. It just needs a review

@ElliottKasoar ElliottKasoar mentioned this pull request Sep 19, 2025
Closed
@inimaz

inimaz commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Hello @LuisBlanche, you might have some conflicts there. Can you resolve them? Like this we might be able to merge this thanks!

@inimaz inimaz added the question Further information is requested label Jul 30, 2026
@davidberenstein1957

davidberenstein1957 commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

Last ping before closing: the macmon-based reader for Apple Silicon is still something we want, but the branch has been conflicting since spring and there has been no reply to the July ping. If there is no update in two weeks I will close this; the branch stays available to restart from.

@benoit-cty

benoit-cty commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Hello @SaboniAmine can you handle it ?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benoit-cty benoit-cty benoit-cty left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@LuisBlanche LuisBlanche

Labels

enhancement New feature or request question Further information is requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sudoless power metrics on Apple Silicon

5 participants

@LuisBlanche @KennethEnevoldsen @inimaz @davidberenstein1957 @benoit-cty