Skip to content

Support Finding Aid deletion operations - #123

Open
ssciolla wants to merge 6 commits into
mainfrom
arc-191-delete
Open

ssciolla wants to merge 6 commits into
mainfrom
arc-191-delete

Conversation

@ssciolla

@ssciolla ssciolla commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

This PR aims to resolve ARC-191.

Testing instructions

  • After building, run the app using --profile, i.e. docker compose --profile app up
  • Enter the app container, i.e. docker compose exec bash.
  • Index an EAD, i.e. arclight:ingest_file[<repo_slug>,<file_name>]
  • Run boxwalker:delete_finding_aid[<eadid>]
  • Check site or Solr to see if documents are gone, and data directory to see if the related generated files (PDF, HTML, and XML) are gone.

@ssciolla ssciolla added bug Something isn't working enhancement New feature or request labels Sep 24, 2026
@ssciolla
ssciolla requested a balanced review from Copilot September 28, 2026 21:02
@ssciolla
ssciolla marked this pull request as ready for review September 28, 2026 21:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Missing-file handling, unescaped Solr identifiers, and absent task validation can prevent or dangerously broaden deletion.

Review effort: Balanced
Findings: 1 High severity · 2 Medium severity

Open (3)

Comment thread app/services/finding_aid/delete_from_index.rb Outdated
Comment thread app/services/finding_aid/delete_generated_files.rb Outdated
Comment thread lib/tasks/delete.rake Outdated
…ore delete query, adding spec; include force flag on FileUtils.rm to ensure DeleteFromIndex is still run when files are missing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants