Skip to content

Fix disabled all_results button, overriding arclight view _group_toggle - #133

Open
rshiggin wants to merge 1 commit into
mainfrom
arc-198-restore-functionality-all-results-btn
Open

rshiggin wants to merge 1 commit into
mainfrom
arc-198-restore-functionality-all-results-btn

Conversation

@rshiggin

@rshiggin rshiggin commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

Override Arclight view with UM custom version. Adds ?group=false || ?group=true to URL query when user toggles "All results" and "Grouped by collection" on search_results page.

Default remains "Grouped . . . "

 <div class="result-type-group btn-group" role="group" aria-label="<%= t('arclight.views.index.group_results') %>">
   <%= link_to t('arclight.views.index.all_results'),
-              search_catalog_path(search_without_group),
+              search_catalog_path(search_without_group.merge('group' => 'false')),
               class: "btn btn-outline-secondary #{'active' unless grouped?}"
   %>
   <%= link_to t('arclight.views.index.group_by_collection'),

The "All results" link previously removed "group" entirely. Adding group=false makes the user’s choice survive the defaulting logic.

@rshiggin
rshiggin marked this pull request as ready for review September 30, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant