Skip to content

[18.09 backport] Fix panic in drivers/overlay/encryption.go - #2484

Merged
selansen merged 1 commit into
moby:bump_18.09from
thaJeztah:18.09_backport_fix_key_spi_panic
Nov 16, 2019
Merged

selansen merged 1 commit into
moby:bump_18.09from
thaJeztah:18.09_backport_fix_key_spi_panic

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

backport of #2462

Issue - "index out of range" panic in drivers/overlay/encryption.go:539
due to a mismatch in indices between curKeys and spis due to
case where updateKeys might bail out due to an error and
not update the spis

Fix - Reconfigure keys when there is a key update failure

Signed-off-by: Arko Dasgupta arko.dasgupta@docker.com
(cherry picked from commit 4420ee9)
Signed-off-by: Sebastiaan van Stijn github@gone.nl

Issue - "index out of range" panic in drivers/overlay/encryption.go:539
due to a mismatch in indices between curKeys and spis due to
case where updateKeys might bail out due to an error and
not update the spis

Fix - Reconfigure keys when there is a key update failure

Signed-off-by: Arko Dasgupta <arko.dasgupta@docker.com>
(cherry picked from commit 4420ee9)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah

Copy link
Copy Markdown
Member Author

@arkodg @selansen ptal

@selansen selansen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@selansen
selansen merged commit 48722da into moby:bump_18.09 Nov 16, 2019
@thaJeztah
thaJeztah deleted the 18.09_backport_fix_key_spi_panic branch November 16, 2019 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants